[#22354] - [4.0] Remove the deprecated code in the CacheController class
- Fixed in Code Base
- 18 Oct 2018
- Medium
- Build: 4.0-dev
- # 22354
- Diff
- Digital-Peak:j4/deprecate/remove/cache
User tests: Successful: Unsuccessful:
Remove the deprecated code in the CacheController class.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
What was the issue?
Wait, nevermind. I think it was something to do with turning one of the classes abstract as noted that was giving me problems.
Either way this actually further highlights a problem we have. The get() method has a different signature in each subclass so there's no way to sanely make an abstract or interface method declaration.
Also, you need to make sure all the controller subclasses have the store() method inlined. 2 of the 4 were using this base method declaration.
#12312 for more context.
So either way we copy the function to the extending classes or do revert back the deprecate message.
| Labels |
Added:
?
?
|
||
Ok, copied the store functions to the implementing classes.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-10-18 07:10:53 |
| Closed_By | ⇒ | laoneo |
IIRC I tried this once and it's not as simple as just deleting these methods.