[#22353] - [4.0] Remove the deprecated code in the bootstrap files
- Fixed in Code Base
- 4 May 2019
- Medium
- Build: 4.0-dev
- # 22353
- Diff
- Digital-Peak:j4/deprecate/remove/apps
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Remove the deprecated code in the bootstrap files.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
?
|
||
| Category | Libraries | ⇒ | Administration com_search Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22353.
OK I've been meaning to test some parts of the search plugin but just haven't found the time so can we fix the conflicts here and i'll just merge it and we can find anything in testing in nightly's if there is anything
Fixed
| Labels |
Removed:
J4 Issue
|
||
OK Spent some time looking into the search thing. I'd imagine that code is hacking around something like https://github.com/joomla/joomla-cms/blob/staging/plugins/search/content/content.php#L401 because if we get an admin menu instance here we're never going to be able to find an item id. It's just going to be about getting an SEF URL I guess. Also possible if we get https://github.com/joomla/joomla-cms/blob/staging/plugins/search/content/content.php#L53 out the container then we can force this to always be a site instance which is more sane anyhow.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 15:25:08 |
| Closed_By | ⇒ | wilsonge |
Still unconvinced RE: the above. But we need to continue cleanup for beta. So we can always bring some form of that code back if essential
Removed the JSite hacks in the search component. I tried the searches in the front and gathered statistics for the back end. Never got an issue because of a missing JSite class.