J3 Issue ?
avatar oorzaak
oorzaak
23 Sep 2018

Steps to reproduce the issue

I needed a module that shows a manual selection of tags; as far as I know this is not possible at present using Joomla core modules. However I found a way to add this option with just one line of code to the module Tags Popular.

I contacted Roland Dalmulder about his and he advised me to submit as a Pull Request to add this line to the core. I'm not sure how to create a pull request so if I'm doing this wrong I hope that someone will be so kind to help me ?

Expected result

Actual result

System information (as much as possible)

Additional comments

In mod_tags_popular.xml I added an extra option to the parameter field order_value. See attached txt file for the code of this option.

If selected, the module shows the tags in the order as set manually in the Tags component. This can be combined with setting the maximum number of tags in order to create your custom selection (up to the overall maximum of 20).

Please note that in this case the module does not take into account the "popularity" of the tag. This is exactly as I needed but it may conflict with the idea of the module: showing popular tags. However, the Random option of the module doesn't take that into account either (as a matter of fact, when selecting my cusom option the execution of the module script follows the same 'logical path' through the code as when selecting the Random option).

It might be a good idea to add some instruction about this. Apart from that, I think this offers some nice extra fuctionality and I was surprised at how easy it was to add this.

Kind regards,

Frits Jongbloets

avatar oorzaak oorzaak - open - 23 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Sep 2018
avatar oorzaak
oorzaak - comment - 23 Sep 2018

Hmm, attachment seems not te be present. I'll try again:

mod_tags_popular-extra-option.txt


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22340.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Sep 2018
Category com_tags com_tags Feature Request
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Sep 2018
Category com_tags Feature Request com_modules com_tags Feature Request
avatar ReLater
ReLater - comment - 23 Sep 2018

Here you find a documentation how you can provide a pr using your browser:
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

Have a look on the Branch select box before you start with step "Find the file you want to modify on Github". "Staging" is the right one at the moment for Joomla 3 and your issue.

Don't be shy ;-) You'll break nothing with these steps and other users and/or magic tools will leave their comments if something more has to be done.

A clear and step-by-step testing instruction for dump testers like me is always a must. Screenshots are always welcome if helpful. One can easily drag and drop them into the pr description.

avatar brianteeman brianteeman - change - 25 Sep 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 25 Sep 2018
avatar oorzaak
oorzaak - comment - 26 Sep 2018

I added a pull request #22384 for my proposal. Maybe this issue #22340 should be closed / deleted?

Frits

avatar ReLater
ReLater - comment - 26 Sep 2018

If you provide a pr and the issue is yours you can close the issue. If it's not your own issue somebody else will close it because you don't have the rights then.

avatar oorzaak
oorzaak - comment - 26 Sep 2018

Thanks for your help. Closing ths issue now.

avatar oorzaak oorzaak - close - 26 Sep 2018
avatar oorzaak oorzaak - change - 26 Sep 2018
Status New Closed
Closed_Date 0000-00-00 00:00:00 2018-09-26 13:47:10
Closed_By oorzaak
avatar Holleyjolley
Holleyjolley - comment - 30 Sep 2019

Hej,
thank you for this proposal. Exactly what I am looking for. I managed to add this additional option and selected the order-option in the module but if I choose a tag (without existing sub-tags) the module outputs "no tags found". Do I have to undertake any other changement e.g. in tags options?
Thank you.

Add a Comment

Login with GitHub to post a comment