Can someone stop to think if this wording accurately describes what it is intended to do. For example there is no mention that this is "excluding search engine generated 'clicks' from the hit count". It just says it excludes robots which is not technically accurate.

Finally I am still not convinced that this is a useful addition to the core of joomla and is better placed as an extension. If this is accepted then we should have the same option everywhere that we record a "hit"

Sorry, i think this is not the same. For the banners it's more important. If i see statistics of one of my sites:
real user make about 3 000 page views/impressions per day
search engines make about 13 000 !!! And all can be excluded...
If i want sell views/impressions, i can't..

Why can't we make it more accurate? This is only an option...

Make better wording is always welcome.

and maybe i do not understand all what you say, but here is nothing to exclude "click", only views/impressions

Finally I am still not convinced that this is a useful addition to the core of joomla and is better placed as an extension. If this is accepted then we should have the same option everywhere that we record a "hit"

Really? Why joomla have this in the core? Why we should create new extension for only one option? Joomla banners component is not perfect, but we can make it better.
It is Joomla politic? Make Joomla extensions not good and say "install third party extension they work better".

The wording is indeed confusing. The feature, in its simplicity, looks OK to me. I see no reason to refuse it.

The wording is indeed confusing.

I will be glad to change the text to more suitable. Someone will advise more suitable texts?
Maybe like this.
Label: Search engines increase banner impressions count
Description: If set to NO, detected search engines would not increase impressions count of banner.

I must say I did not test the code and results, though. Therefore it needs testing as I work local.

Regarding usability, I can't think of a scenario where user would want this in one module but not in another. Perhaps this should be set globally in com_banners instead of individually in each banner module?

I must say I did not test the code and results, though. Therefore it needs testing as I work local.

Its can be tested local too. For example in Firefox you can open Developer tools and start Responsive/Mobile view, then add new Device with any user agent.

Regarding usability, I can't think of a scenario where user would want this in one module but not in another. Perhaps this should be set globally in com_banners instead of individually in each banner module?

yes, I agree.

I have tested this PR with #22368 it show very fine result. ~700 impressions per hour before and ~250 impressions per hour after patch.

Maybe i commit one more "option" to ignore click made by robots by the same way? Or should it be different PR?

Maybe for the strings:
COM_BANNERS_FIELD_TRACKROBOTSIMPRESSION_LABEL="Impressions by Search Engines"
COM_BANNERS_FIELD_TRACKROBOTSIMPRESSION_DESC="If set to NO, prevents search engines clicks from increasing the number of impressions."

Be sure to sort the keys in alpha order.

Be sure to sort the keys in alpha order.

I don't understand where is it wrong?

COM_BANNERS_FIELD_TRACKROBOTSIMPRESSION_LABEL="Impressions by Search Engines"

This is good!

COM_BANNERS_FIELD_TRACKROBOTSIMPRESSION_DESC="If set to NO, prevents search engines clicks from increasing the number of impressions."

in this PR is only impressions ignoring, not clicks

@brianteeman what do you think now?

I have tested this item ✅ successfully on 2f36648

I have tested this item ✅ successfully on 2f36648

RTC