Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22304] - Preview module positions needing language strings

J3 Issue ?
avatar ciar4n
ciar4n
21 Sep 2018

Steps to reproduce the issue

Module position preview using static text for Position and Style. I suspect these should be language strings?

Expected result

Language strings for Position and Style

Actual result

https://github.com/joomla/joomla-cms/blob/staging/templates/system/html/modules.php#L147

System information (as much as possible)

Additional comments

avatar ciar4n ciar4n - open - 21 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Sep 2018
avatar brianteeman
brianteeman - comment - 21 Sep 2018

If those strings are translatable in the UI (which I believe they are) then yes they should be language strings

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Sep 2018
Status New ⇒ Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Sep 2018
Category ⇒ Language & Strings
avatar brianteeman brianteeman - change - 21 Sep 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 21 Sep 2018
avatar infograf768
infograf768 - comment - 24 Sep 2018

@ciar4n
Will do patch if you have not yet.
I will use
JGLOBAL_PREVIEW_POSITION="Position: "
JGLOBAL_PREVIEW_STYLE="Style: "

in en-GB.ini frontend

avatar ciar4n
ciar4n - comment - 24 Sep 2018

Please go for it. I meant to do it after #22272 got merged but duly forgot about it!

Thank you.

avatar infograf768 infograf768 - change - 25 Sep 2018
Status Discussion ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-25 05:15:41
Closed_By ⇒ infograf768
avatar infograf768
infograf768 - comment - 25 Sep 2018

please test #22365

avatar infograf768 infograf768 - close - 25 Sep 2018

Add a Comment

Login with GitHub to post a comment