? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
14 Sep 2018

Pull Request for Issue #22118 .

Summary of Changes

Will cause notifications to be above the headers.

Testing Instructions

go to extension manager click on notification bell in top right.
drop down will be obscured by header.
install patch
now drop down will be above the header

Expected result

after

Actual result

before

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 14 Sep 2018
avatar N6REJ N6REJ - change - 14 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2018
Category Administration Templates (admin)
avatar N6REJ N6REJ - change - 14 Sep 2018
Title
notification dropdown to top
Make Notification Dropdown viewable.
avatar N6REJ N6REJ - edited - 14 Sep 2018
avatar infograf768
infograf768 - comment - 15 Sep 2018

I have tested this item successfully on fb1771a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22186.

avatar infograf768 infograf768 - test_item - 15 Sep 2018 - Tested successfully
avatar laoneo
laoneo - comment - 15 Sep 2018

@ciar4n is z index a way to go?

avatar ReLater
ReLater - comment - 15 Sep 2018

install patch

Please tell the people that pr is not testable with patchtester. Needs npm.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Sep 2018

Please tell the people that pr is not testable with patchtester

needs a Select for PR-Creator if Patchtester can be used.

avatar mbabker
mbabker - comment - 15 Sep 2018

Please tell the people that pr is not testable with patchtester

needs a Select for PR-Creator if Patchtester can be used.

I'm going to be real honest here. The issue tracker is very underutilized in relation to just using GitHub (the traffic stats for this repo are exponentially higher than the traffic stats for the entirety of the issue tracker subdomain, like the traffic for one day on GitHub exceeds one week on the tracker). Given the project's limited resources, especially when it comes to things outside the CMS' development (look how few contributors we have to the .org apps or the Joomla Framework repos or com_patchtester itself), we're better off investing time into a carsonbot type solution or any of the existing bots in the GitHub ecosystem than doing another round of heavy investment of time and resources into the tracker.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Sep 2018

+1 for whatever Solution provide 1 instead 2 Sources to maintain.

avatar N6REJ
N6REJ - comment - 16 Sep 2018

install patch

Please tell the people that pr is not testable with patchtester. Needs npm.

Sorry about that, It's for 4.0-dev which requires npm to build from git so I assumed that was enough.

avatar N6REJ
N6REJ - comment - 16 Sep 2018

@ciar4n is z index a way to go?

Any reason why it might not be?

avatar richard67
richard67 - comment - 16 Sep 2018

I have tested this item successfully on fb1771a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22186.

avatar richard67 richard67 - test_item - 16 Sep 2018 - Tested successfully
avatar infograf768 infograf768 - change - 16 Sep 2018
Title
Make Notification Dropdown viewable.
[4.0] Make Notification Dropdown viewable.
avatar infograf768 infograf768 - edited - 16 Sep 2018
avatar infograf768 infograf768 - change - 16 Sep 2018
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 16 Sep 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22186.

avatar laoneo
laoneo - comment - 17 Sep 2018

ciar4n is z index a way to go?

Any reason why it might not be?

Yes, because when start throwing around with z-indexes without a plan we will get sooner or later into a mess. I just want to have confirmation from @ciar4n if this is ok like that.

avatar ciar4n
ciar4n - comment - 17 Sep 2018

I think this should be fine! ?

avatar wilsonge wilsonge - change - 17 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-17 11:30:05
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 17 Sep 2018
avatar wilsonge wilsonge - merge - 17 Sep 2018
avatar wilsonge
wilsonge - comment - 17 Sep 2018

Perfect. Thanks guys!

avatar ReLater
ReLater - comment - 17 Sep 2018

Yes, because when start throwing around with z-indexes without a plan we will get sooner or later into a mess

Using $zindex-* variables could help a bit to get rid of too many different values.

avatar laoneo
laoneo - comment - 23 Sep 2018

@ReLater pr's welcome :)

Add a Comment

Login with GitHub to post a comment