Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#22185] - [4.0] Fix missed subform field

? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
14 Sep 2018

Pull Request for Issue #22183

Summary of Changes

I guess at some merge conflict the subform CE was acidently removed from settings.json
The patch fix it.

Testing Instructions

Apply patch, run npm install

Add subform field somwhere, example to Custom Module
/modules/mod_custom/mod_custom.xml

<field type="subform" name="subform" label="Subform1" multiple="true">
  <form>
    <field type="text" name="text1" label="Text1"/>
      <field type="subform" name="subform_nested" label="Subform Nested" multiple="true"
			   default='[{"text_nested":"ueue"}]'>
        <form>
            <field type="text" name="text_nested" label="Text nested"/>
        </form>
    </field>
  </form>
</field>

Go to any Custom Module and try edit this field.

Expected result

Field working

Actual result

Field not working

Documentation Changes Required

nope

avatar Fedik Fedik - open - 14 Sep 2018
avatar Fedik Fedik - change - 14 Sep 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Sep 2018
Category ⇒ Repository
avatar Fedik Fedik - change - 14 Sep 2018
The description was changed
avatar Fedik Fedik - edited - 14 Sep 2018
avatar continga
continga - comment - 14 Sep 2018

I have tested this item ✅ successfully on 6b2ac0f

Tested this successfully, subforms can now be used again.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22185.

avatar continga continga - test_item - 14 Sep 2018 - Tested successfully
avatar laoneo laoneo - close - 15 Sep 2018
avatar laoneo laoneo - merge - 15 Sep 2018
avatar laoneo laoneo - change - 15 Sep 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-15 06:05:53
Closed_By ⇒ laoneo
Labels Added: ?
avatar laoneo
laoneo - comment - 15 Sep 2018

Well done. Thanks

Add a Comment

Login with GitHub to post a comment