?
avatar infograf768
infograf768
13 Sep 2018

Pull Request for Issue #18552
(The original issue, plus the further discovered ones with Publishing Options)
Plus solving other bug.

Summary of Changes

  1. Adding hidden id field in layouts/joomla/edit/global.php
  2. Moving code for the allowed categories to choose from in Select Target to the correct view
  3. Solving #18552 by preventing race condition caused by loading Target iframe at the same time as Reference. Thank you Robbie Jackson !!!

Testing Instructions

Set a multingual sites with some articles associations and some categories set to All languages and different content languages.

Bug1.
In Articles Global Options, set Show Publishing Options to hide

screen shot 2018-09-13 at 15 33 56

Go to the multilingual component. Choose articles and a language. Try to load the sidebyside for an article ot its associated item. We get in a loop.

jform_id

Bug2.
Load the side by side view from clicking on an article or contact or Newsfeed (after setting Show Publishing Options back to Show.
In the Target part click on Select Target (or Change Target to load the modal.
In the modal click on SearchTools.
Then click on Select a Category
The dropdown will display all categories, although it should ONLY display categories tagged to ALL languages or to the language of the Target item.

screen shot 2018-09-13 at 15 52 29

Bug3.
Filter by articles and one of the Content languages.
The items already associated show as a grey button.
Click on one of these grey buttons to load the side by side page with the already defined target (tagged to the language of the grey button)

The first time one clicks, the already associated target first appear for a while and then disappear to finally display a blank article.
Close the side by side page and then click again the same grey button.
This time all is fine, the already associated target displays fine.

com_assoc

This may depend on the session and cache used on site. I get this all the time on my test sites

After patch

Bug1 solved as we always have a jform_id obtained from the hidden id field

Bug2 solved

screen shot 2018-09-13 at 15 40 37

Bug3 solved. No need to reload.

Documentation Changes Required

None

avatar infograf768 infograf768 - open - 13 Sep 2018
avatar alikon
alikon - comment - 13 Sep 2018

i've tested succesfully
but unable to mark it on Issue Tracker cause this pr is not listed
same as #22175 (comment)

p.s
maybe the Issue Tracker don't like PR from @infograf768
?

avatar wojsmol
wojsmol - comment - 13 Sep 2018

@alikon This PR is listed correctly for me in issue tracker.

avatar alikon
alikon - comment - 13 Sep 2018

screenshot from 2018-09-13 21-23-20

@wojsmol
i belive you
but believe me i'm not able to use gimp ?

update
now i can see it but still cannot mark the test result

maybe some cron jobs is going to have a break ?

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Sep 2018
Category com_associations
avatar infograf768
infograf768 - comment - 14 Sep 2018

Test button issue cconfirmed.
One more tester needed here as we can RTC and merge here eventhough we have this issue with the test button.

avatar infograf768 infograf768 - change - 14 Sep 2018
Status Discussion Pending
avatar zero-24 zero-24 - change - 17 Sep 2018
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 17 Sep 2018

Issues described here are fixed by the patch provided. Thanks @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22166.

avatar mbabker mbabker - change - 18 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-18 01:25:16
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Sep 2018
avatar mbabker mbabker - merge - 18 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2018
Category com_associations Administration com_associations Layout JavaScript

Add a Comment

Login with GitHub to post a comment