[#22164] - [4.0] Choose how we want to add browser specific Polyfills
- Closed
- 26 Jan 2022
- Medium
- Build: 4.0-dev
- # 22164
Steps to reproduce the issue
From the conversation in #22100 there are several ways to attach a polyfill
- Server side browser detection to insert the js file
- Client side browser detection to insert the js file (I believe the way that @dgrammatiko preferred)
- Always include the JS but bail early we don't need to patch
Disadvantages of each:
- If there are proxies in front then server detection can fail. Practically given most the polyfills are IE and most IE usage is in corporates with proxies this could be significant
- Including other JS files with javascript isn't very clean (but guarantees support added where required)
- Means the JS file is always loaded increasing page load time of first page load.
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | JavaScript |
Polyfills are still very relevant in the ESxxxx land so this still needs to be addressed
jwaisner
- | Status | Discussion | ⇒ | Confirmed |
| Build | master | ⇒ | 4.0-dev |
This is still relevant. The missing polyfill is one tiny file: https://www.npmjs.com/package/dom4 but also we NEED to review the ES5 files (or just remove them as right now they are not functional AFAIK)
About the loading: is far easier, just load the js with a nomodule attribute and without any defer/async. Make sure that is in the dependencies in the WAM. That's it, no sniffing no extra processing...
so this should be marked as a release blocker
so this should be marked as a release blocker
Depends on the severity of IE11 support
The ie poly fills are irrelevant so this can be closed @richard67
Closing for reason stated in the previous comment.
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-26 20:00:02 |
| Closed_By | ⇒ | richard67 |
@wilsonge is this still relevant now ie11 support is dropped?