? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
13 Sep 2018

Pull Request for Issue #22095 .

Summary of Changes

This PR fixes issue Export of User Actions Log keeps popping up after export error as described in #22095 .

Testing Instructions

  1. Log in to administrator area of your site
  2. Access to Users -> User Actions Log
  3. Press one of the two export buttons to export actions log
  4. Before patch: If you try to press Search or Clear button , the system keep exporting user actions log.
  5. After path: It won't export actions log anymore (Perform correct action search or clear as expected)

Documentation Changes Required

None

avatar joomdonation joomdonation - open - 13 Sep 2018
avatar joomdonation joomdonation - change - 13 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2018
Category Administration
avatar Sandra97
Sandra97 - comment - 13 Sep 2018

I have tested this item ? unsuccessfully on 9c03a77

When I click on "Export All as CSV", instead of having the popup, it displays a message "There are no User Action logs to export."
It works as expected for "Export Selected as CSV".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22155.
avatar Sandra97 Sandra97 - test_item - 13 Sep 2018 - Tested unsuccessfully
avatar joomdonation joomdonation - change - 13 Sep 2018
Labels Added: ?
avatar joomdonation
joomdonation - comment - 13 Sep 2018

Sorry my bad. Found the error and fixed it. Could you please help testing it again?

avatar Sandra97
Sandra97 - comment - 13 Sep 2018

I have tested this item successfully on a1ff986

It works as expected now. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22155.

avatar Sandra97 Sandra97 - test_item - 13 Sep 2018 - Tested successfully
2f7dc92 13 Sep 2018 avatar joomdonation CS
avatar BurtNL
BurtNL - comment - 13 Sep 2018

I have tested this item successfully on 2f7dc92

Applied the patch, tested both exports and the other buttons, all works well!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22155.

avatar BurtNL BurtNL - test_item - 13 Sep 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

Thanks for Comment, @joomdonation.

Ready to Commit after two successful tests.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

Will set RTC later as Issue Tracker didn't response.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

Set Status on Ready to Commit fails by
bildschirmfoto 2018-09-13 um 16 33 05

Can anyone try?

avatar Quy
Quy - comment - 13 Sep 2018

@franz-wohlkoenig Confirmed same error.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

@Quy thanks for taking Time.

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Sep 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

Ready to Commit after two successful tests.

avatar elkuku
elkuku - comment - 13 Sep 2018

Set Status on Ready to Commit fails by

That looks bad - If it happens regularly, you should open an issue...

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

you should open an issue...

This and similar Issues happen from Time to Time, but most it works so i guess its about Traffic / slow Internet.

avatar mbabker mbabker - change - 15 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-15 16:29:17
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 15 Sep 2018
avatar mbabker mbabker - merge - 15 Sep 2018

Add a Comment

Login with GitHub to post a comment