?
avatar Open2logic
Open2logic
13 Sep 2018

Steps to reproduce the issue

  1. Create new administrator menu.

  2. Create new item for this new menu
    a

  3. Select this item and click in Batch button.

To Move or Copy your selection please select a Menu or parent item.

  1. Select Move or Copy
    ¿Where is the process button?
    b

c

Expected result

That the button to process is visible

Actual result

There is no button to process

System information (as much as possible)

Joomla 3.9.12

Additional comments

avatar Open2logic Open2logic - open - 13 Sep 2018
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Sep 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

Issue confirmed.

@Open2logic can you please test if this happens in 3.8 too?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22154.

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Sep 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Sep 2018
Category com_menus UI/UX
avatar richard67
richard67 - comment - 13 Sep 2018

@franz-wohlkoenig I think he meant 3.8.12 because there is no 3.9.12 (yet).

avatar Open2logic
Open2logic - comment - 13 Sep 2018

Sorry.

3.8.12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22154.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Sep 2018

ah, i thought 3.9 is meant.

avatar infograf768
infograf768 - comment - 13 Sep 2018

@izharaazmi
can you have a look?

avatar izharaazmi
izharaazmi - comment - 13 Sep 2018

I'll have a look soon.

avatar infograf768
infograf768 - comment - 13 Sep 2018

the code is

<?php if ((strlen($menuType) && $menuType != '*' && $clientId == 0) || ($published > 0 && $clientId == 1)): ?>
	<button class="btn btn-success" type="submit" onclick="Joomla.submitbutton('item.batch');">
		<?php echo JText::_('JGLOBAL_BATCH_PROCESS'); ?>
	</button>
<?php endif; ?>

As one can see, when clientId == 1 (admin menu) then we need the state to be Published > 0.

The issue is solved when Search Tools Status is set to Published.

screen shot 2018-09-13 at 18 15 35

screen shot 2018-09-13 at 18 16 25

No idea why this was implemented this way.

EDIT: No idea either why we have strlen($menuType)

avatar infograf768
infograf768 - comment - 13 Sep 2018

The issue comes from #18195

avatar infograf768
infograf768 - comment - 13 Sep 2018

see also
#19879 (for 4.0)

avatar izharaazmi
izharaazmi - comment - 14 Sep 2018

I just checked it and I see #19879 does fix this right. However I am not sure why we can't process trashed items, any idea?

avatar infograf768
infograf768 - comment - 14 Sep 2018

We could, but is it a good idea? I think not. Most of the time (99%), if some stuff is in Trash and remained in trash, it was because someone forgot to delete it.

As #19879 is towards 4.0, I suggest to make a similar PR towards staging. Will you do?

avatar izharaazmi
izharaazmi - comment - 14 Sep 2018

@infograf768 Please see whether #22178 is acceptable. If not I'll do it the old way.

avatar infograf768
infograf768 - comment - 14 Sep 2018

Closing as we have patch #22178

avatar infograf768 infograf768 - change - 14 Sep 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-09-14 07:07:17
Closed_By infograf768
avatar infograf768 infograf768 - close - 14 Sep 2018

Add a Comment

Login with GitHub to post a comment