[#22149] - [4.0] [a11y] SkipTo Links for Atum
- Closed
- 25 Sep 2018
- Medium
- Build: 4.0-dev
- # 22149
- Diff
- brianteeman:plg_system_a11y
User tests: Successful: Unsuccessful:
Based on https://github.com/paypal/skipto
SkipTo is a replacement for your old classic "Skipnav" link. The script dynamically determines the most important places on the page and presents them to the user in a drop-down menu.
The menu makes it easier for keyboard and screen reader users to quickly jump to the desired location by simply choosing it from the list of options.
It is activated on the first press of the tab key (or by pressing the accesskey ctrl-0, cmd=0)
IMPORTANT NOTE we have not finished ensuring that all the parts of the page are in the correct landmark yet - that's beyond the scope of this
BUG - Help Required Since recording the examples below I moved the strings to the correct file but for some reason I can't see they are not loading
I have only enabled this for the admin but we could add a param to enable it in the frontend as well
Static image
Animation showing that after selecting an item the keyboard has focus on that item
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql Language & Strings Modules Repository JavaScript Installation Libraries Front End Plugins |
| Labels |
Added:
?
?
|
||
@brianteeman , just FYI if you want to modify the config without changing the core file:
I am well aware however that only lets you change things that have not been changed here. Although I was considering offering some customisation of the plugin with the settings in the plugin
For the record the only changes are
- Use JTEXT instead of hard coded strings
- Do not include the ie8 shim
- Do not embed the css in the js but keep as a separate file
So I've just got paypal/skipto#42 merged which is the last of the string overrides. We should use the API wherever possible to reduce any core hacks (i.e. inject the strings via the config option). If we have an ie8 shim we have an ie8 shim i guess (or we can try and build it ourselves) - and css/js split up i'll have to review (but as far as I can see the css is split out? https://github.com/paypal/skipto/tree/master/src/css) - but I'm strongly biased to not core hacking if there isn't a major product need to.
Thanks @wilsonge - the problems come from their grunt scripts afaict
CSS
https://github.com/paypal/skipto/blob/master/src/js/skipTo.js#L82
Shim
It is being compiled by the grunt script
https://github.com/paypal/skipto/blob/master/Gruntfile.js#L80
Re-writing this to override instead of customise
Closed - obviously no one else is interested in improving the accessibility in joomla 4
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-25 18:26:05 |
| Closed_By | ⇒ | brianteeman |
? My understand was you were rewriting this to override?
the a11y team is showing no interest in testing anything - so I am not going to waste my time writing code that wont get tested and therefore wont get merged
hello i think a11y team is ready to test anything but it difficult to test something changing many time (not this but admin template is realy difficult to follow dev)... i think it a realy good addition and we will test it asap for sure
=> maybe you can send a bump on glip to help us to follow your great addition !
i am realy happy to see that you fight for a better j4 accessibility we try to do better
I am not using glip. This is the joomla issue tracker for joomla code. Glip is just a time waste. I also posted it on the a11y team GitHub tracker. I shouldn't have to chase for people to test something.
The only real changes in the admin template in the last six months are all a11y related written by me.
Dear @brianteeman. People sometimes have their own personal problems that exclude them from normal life. I'm back. Today, the furthest tomorrow, I start testing. Unfortunately, the a11y team may be large, but we don't have too many testers ready for such tests.
Please re-open this PR in order to carry out accessibility tests
@Quy @franz-wohlkoenig Please reopen as requested by @zwiastunsw above.
No it is my pr and I do not want it re-opened at this time
Where is this system documented? I specifically asked George before I started this PR. If I had fund the documentation I would have followed it. I am not wasting my time trying to reverse engineer something.