? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
9 Sep 2018

Summary of Changes

class JFormFieldSkins extends JFormFieldFolderList

Testing Instructions

  1. Go to http://skin.tinymce.com and select the preset charcoal or tundra and download it. (lightgray is the one that ships with Joomla!)
  2. Extract the skin in /media/editors/tinymce/skins
  3. Go to plugins->tinyMCE
  4. Select a set with administrator (admin) or guest (site) assigned
  5. Select the skin you just copied.
  6. Edit an article with your new skin (admin or site side).
avatar twister65 twister65 - open - 9 Sep 2018
avatar twister65 twister65 - change - 9 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2018
Category Front End Plugins
avatar twister65 twister65 - change - 9 Sep 2018
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 9 Sep 2018

I don't think this is correct. JPATH_ROOT already handles this.

avatar twister65
twister65 - comment - 9 Sep 2018

you are right, it is not correct.
I'm trying to find a fix.
Sorry.

avatar twister65 twister65 - change - 9 Sep 2018
Title
Fix TinyMCE skin admin directory
Class JFormFieldSkins extends JFormFieldFolderList (TinyMCE skin)
avatar twister65 twister65 - edited - 9 Sep 2018
avatar twister65 twister65 - change - 9 Sep 2018
The description was changed
avatar twister65 twister65 - edited - 9 Sep 2018
avatar twister65
twister65 - comment - 9 Sep 2018

I forgot to select a set with administrator assigned, when I changed the administrator skin.

avatar SharkyKZ
SharkyKZ - comment - 18 Sep 2018

Because of B/C reasons this new PR needs to be done against 4.0, I think.

avatar twister65 twister65 - close - 21 Sep 2018
avatar twister65 twister65 - change - 21 Sep 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-09-21 15:23:20
Closed_By twister65
avatar SharkyKZ
SharkyKZ - comment - 21 Sep 2018

The change in parameter values. Currently, numbers from glob() are used as values. With the change, actual folder names are used. So user-set value is nullified which I'm sure most will say is a B/C break.

Add a Comment

Login with GitHub to post a comment