[#22096] - SiteRouter decodes + symbols to spaces in URL paths
- Closed
- 22 Feb 2023
- Low
- Build: staging
- # 22096
Steps to reproduce the issue
- Create a component router that creates/handles URLs with segments containing + symbols (eg. an email with a user alias element such as in https://mysite.org/menuitemalias/user+alias@example.com/)
- Attempt to open such a URL and log the content of the segments supplied to the component router
Expected result
Given the above URL, the first segment supplied the the parse() method of the component router should be the email address as given. (To my understanding, + symbols only have special meaning within the query component of a URL, but should be treated literally within the URL path (ref discussion here: https://stackoverflow.com/questions/1005676/urls-and-plus-signs).
Actual result
The + symbol in the URL is translated to a space character before being passed to the component router.
System information (as much as possible)
Joomla 3.8.10, Ubuntu 14.04, Apache 2.4.29
Additional comments
I've tracked this back to the use of urldecode() in libraries/src/Router/SiteRouter.php (line 89). Replacing this with rawurldecode() addresses the problem (though I have not done extensive testing to understand what other implications this change may have).
joomla-cms-bot
- 
| Status | New | ⇒ | Information Required |
| Category | ⇒ | com_mailto |
brianteeman
- | Labels |
Added:
J3 Issue
|
||
Thanks Franz... had not actually realised there were updates - seems there was a DB schema fix waiting for me to push through before I was alerted to the updates. Have done that now and updated to 3.8.12. Problem is as before.
I spent a few minutes searching through the current PRs and issues but have not yet spotted the same issue there.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22096.
| Status | Information Required | ⇒ | Discussion |
| Build | 3.8.10 | ⇒ | 3.8.12 |
Interesting... it does include reference to this problem alright. The PR there would not resolve this fully though as far as I can tell from perusing the changes.
| Status | Discussion | ⇒ | Information Required |
| Build | master | ⇒ | staging |
@johnrix are you still experiencing this in 3.9.16 or the latest staging branch for 3.9?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22096.
Was able to confirm with a test there now also that it is still behaving the same way.
| Status | Information Required | ⇒ | Confirmed |
Hackwar
- | Labels |
Added:
No Code Attached Yet
bug
Removed: ? |
||
richard67
- | Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-22 22:22:21 |
| Closed_By | ⇒ | richard67 |
can you please update to latest Version (you are on 3.8.10) and retest?
There are also some similar Issues + Pull Requests open - can you please look if they are about same Topic?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22096.