[#22093] - [4.0] Possible PR for #22091 view=menus change behaver list switch to edit
- Closed
- 3 Oct 2019
- Medium
- Build: 4.0-dev
- # 22093
- Diff
- Didldu-Florian:patch-6
- Success Hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22091
Summary of Changes
Change event to edit insted of list view change as described and suggested in #22091
$canManageItems ist also not more needed, simply simplified and the known way.
Actual result
of com_menus&view=menus
Expected result
of com_menus&view=menus
Testing Instructions
The Screenshots should be selfexplained, just test if it does the new expectation
Additional comments
In J3 we had a edit button. Clicking on a menu item was also in J3 for me a bit confused, why i will jump to items. And now, in J4 the edit button was moved, but now we have a pencil and it did not edit, it did even jump to items view :/ ? This is really confused and i know no component in joomla where we have such a behaver. If I'm on a list view, i expect to go to edit view after onclick to any item and no to switch the list view ;) Fot this I did done that change.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Title |
|
||||||
| Title |
|
||||||
@franz-wohlkoenig I ad made a PR concerning the bad UX on menuItems. We had some discussion with @infograf768 @brianteeman @Quy. The latest view was like this.
Unfortunately I have lost the branch when installing a new working environment.
Mhh, so we have now to PRs
One does this:
https://user-images.githubusercontent.com/1035262/41524242-167bf048-72dd-11e8-9139-86eb86f6f432.PNG
The other this:
https://user-images.githubusercontent.com/12803406/45255859-e9daee80-b38d-11e8-8671-ac6373c1b2b0.jpg
Hmm, I think both are okay, the one from @chmst wich kept the link to list view and subtext edit feature. And mine, only with edit feture, as you know it from other Joomla components lists.
Well, I guess that leaves the decision question.
@chmst we can recover the change see https://github.com/joomla/joomla-cms/pull/20787/files
@Didldu-Florian I think this can be closed now that #22143 has been merged. Am I correct?
Quy
- 
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-03 04:19:30 |
| Closed_By | ⇒ | Quy |
I had forgotten this one: #20787