? Pending

User tests: Successful: Unsuccessful:

avatar roland-d
roland-d
8 Sep 2018

Pull Request for Issue #22082

Summary of Changes

This makes sure the consent field is set to required.

Testing Instructions

  1. Make sure user registration is enabled
  2. Go to plugins
  3. Filter on privacy
  4. Enable the System - Privacy Consent plugin
  5. Go to the front-end and click on Create an account
  6. Scroll to the bottom of the page and see the Privacy Policy has Optional behind it.

image

7. Apply patch 8. Refresh page 9. Notice the `Optional` is gone

image

When you enable the Privacy Consent plugin the field must be required, otherwise it is useless.

Expected result

Field not to have the text optional.

Actual result

Field has text it is optional.

Documentation Changes Required

None

avatar roland-d roland-d - open - 8 Sep 2018
avatar roland-d roland-d - change - 8 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2018
Category Front End Plugins
avatar crommie
crommie - comment - 8 Sep 2018

I have tested this item successfully on 6cb4176

Tested according to instructions. Result as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22092.

avatar crommie crommie - test_item - 8 Sep 2018 - Tested successfully
avatar alikon
alikon - comment - 8 Sep 2018

I have tested this item successfully on 6cb4176


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22092.

avatar alikon alikon - test_item - 8 Sep 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Sep 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Sep 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 8 Sep 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-08 15:37:15
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 8 Sep 2018
avatar mbabker mbabker - merge - 8 Sep 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Sep 2018

will this be ported to 4.0 as there is an similar open Issue #22056?

avatar mbabker
mbabker - comment - 15 Sep 2018

#22056 has nothing to do with this item (it may look similar but the issue is locally isolated to whatever form is affected, it's not a global thing)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Sep 2018

thanks @mbabker making Issue clear.

Add a Comment

Login with GitHub to post a comment