? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
7 Sep 2018

Alternative for #19837

Summary of Changes

Do not check if the database supports full Unicode characters.

On php >= 7.0 and mysql >= 5.5.3 we should be safe to save utf8mb4.
The same for PostgreSQL and SQLite3.

Testing Instructions

Code review

avatar csthomas csthomas - open - 7 Sep 2018
avatar csthomas csthomas - change - 7 Sep 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2018
Category Libraries
avatar laoneo laoneo - change - 10 Sep 2018
Labels Added: ?
avatar laoneo
laoneo - comment - 10 Sep 2018

Drone is crashing. Can you check if installation is still working with your patch?

avatar csthomas
csthomas - comment - 10 Sep 2018

Yes, I will check it.

avatar csthomas
csthomas - comment - 10 Sep 2018

I installed Joomla with your last merge (and without) and I have not seen any problem related to my patch.

I saw in /instalation/error_log only this:

[10-Sep-2018 09:48:21 Europe/Berlin] PHP Warning:  simplexml_load_file(): I/O warning : failed to load external entity "/home/.../components/com_mailto/mailto.xml" in /home/.../libraries/src/Installer/Installer.php on line 2032
[10-Sep-2018 09:48:21 Europe/Berlin] PHP Warning:  simplexml_load_file(): I/O warning : failed to load external entity "/home/.../components/com_wrapper/wrapper.xml" in /home/.../libraries/src/Installer/Installer.php on line 2032
avatar csthomas
csthomas - comment - 10 Sep 2018

I tested on php 7.1 and mysql 5.7.23 (mysqli, pdomysql)

avatar laoneo laoneo - change - 18 Oct 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-10-18 08:38:12
Closed_By laoneo
avatar laoneo laoneo - close - 18 Oct 2018
avatar laoneo laoneo - merge - 18 Oct 2018
avatar laoneo
laoneo - comment - 18 Oct 2018

Thanks

Add a Comment

Login with GitHub to post a comment