[#22034] - [plg_content_loadmodule] Prevent issues with regular expression characters
- Fixed in Code Base
- 22 Jan 2020
- Medium
- Build: staging
- # 22034
- Diff
- SharkyKZ:plgContentLoadModule_1
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21329.
Summary of Changes
This is an alternative to Rosie-Eagle#1 and #21948.
This fixes the issue of module positions and modules with titles containing special regular expression characters not being loaded.
Testing Instructions
Note, the use of } hasn't been fixed.
Copied from #21329 by franz-wohlkoenig:
- Log in at the backend of joomla
- Go to menu "Extensions > Modules".
- Create a "Custom" module.
- Give field 'title' the following value (without the quotes): "Some math: 1 + 1 = 2"
- Save the module.
- Next create a new article (or edit an existing one).
- Make sure you can later view the article at the fronted of joomla, where visitors normally view the article.
- Enter load module shortcode with your module type and title, e.g.
{loadmodule mod_custom, Some math: 1 + 1 = 2} - Save the article.
- View the article at the frontend of joomla.
Notice "{loadmodule mod_custom, Some math: 1 + 1 = 2}" not beeing replaced by the actual rendering of the module you created at steps 3 to 5. The text "{loadmodule mod_custom, Some math: 1 + 1 = 2}" is still there as if it were untouched.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
| Labels |
Removed:
J3 Issue
|
||
There's an error in testing instructions. The shortcode should contain module name, not just title. So, for example, {loadmodule Some math: 1 + 1 = 2} should become {loadmodule mod_login,Some math: 1 + 1 = 2}.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.
wouldn't it be easier to use preg_quote?
This was meant to be faster but now I'm wondering whether we need to use utf8 string functions from Joomla\String\StringHelper here.
| Title |
|
||||||
No need to use utf8 functions. Works fine like this.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.
@franz-wohlkoenig Please test latest commit.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.
| Status | Pending | ⇒ | Ready to Commit |
RTC as previous test still good (latest commits include only branch updates).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-22 21:47:27 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item? unsuccessfully on 61ff38b
Module isn't rendered also by using this PR.
Note: Append a Module by click on "Module"-Button load it by ID, so this Problem didn't exist.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22034.