[#21969] - [plg_quickicon_phpversioncheck] Correct displayed PHP support date
- Fixed in Code Base
- 3 Sep 2018
- Medium
- Build: staging
- # 21969
- Diff
- SharkyKZ:plgQuickiconPhpversioncheck_1
User tests: Successful: Unsuccessful:
Issue reported by user on forum https://forum.joomla.org/viewtopic.php?f=714&t=965158.
Summary of Changes
This corrects the displayed security support date in PHP version warning.
Testing Instructions
This can be normally tested only on PHP 7.0 setup. Open administrator panel. See date in PHP version warning.
Expected result
Your PHP version, 7.0.31, is only receiving security fixes at this time from the PHP project. This means your PHP version will soon no longer be supported. We recommend planning to upgrade to a newer PHP version before it reaches end of support on 2018-12-03. Joomla will be faster and more secure if you upgrade to a newer PHP version (PHP 7.x is recommended). Please contact your host for upgrade instructions.
Actual result
Your PHP version, 7.0.31, is only receiving security fixes at this time from the PHP project. This means your PHP version will soon no longer be supported. We recommend planning to upgrade to a newer PHP version before it reaches end of support on 2018-09-03. Joomla will be faster and more secure if you upgrade to a newer PHP version (PHP 7.x is recommended). Please contact your host for upgrade instructions.
Documentation Changes Required
No.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21969.
@franz-wohlkoenig looking at the changes I don't think there's much point seeing as nothing I have mentioned has been addressed?
I am putting this change in the language file for discussion:
PLG_QUICKICON_PHPVERSIONCHECK_SECURITY_ONLY="Your PHP version, %1$s, is currently only receiving security fixes from the PHP project. Your PHP version will reach end of support on %2$s. We recommend upgrading to a newer PHP version soon to keep your Joomla installation secure. Please contact your host for upgrade instructions."
The most important information are in short sentences here. I guess that is easier to read. And I removed the advertisement about faster PHP, because that might not be true for all future versions. Like this it is more future proof.
I have tested this item
Tested successfully.
An adaptation of the language string is absolutely necessary in order not to confuse the user and to support the statement of the message.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21969.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-03 17:12:42 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks for helping with this to all. Do we need to open a new issue with a pull request for the language variable? Sorry, I am not doing this often enough.
And what is the opinion on the above mentioned change?
Yes please a new PR with the change to the string would be awesome. It seems good to me but I'm sure when you create the PR @brianteeman will also give it an overview (he reviews the en-GB strings)
I have tested this item
Test successful now showing 03-12-2018
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21969.
Ok, tried my best to get the pull request going. Hope everything is fine with that.
Changed PLG_QUICKICON_PHPVERSIONCHECK_SECURITY_ONLY and tested the ini file in a live site.
Comments are welcome.
Please use this link to submit your PR against the main cms repo:
staging...StefanSTS:StefanSTS-patch-phpversioncheck-lang
You have just send it against your own repo ;)
I am definitely a GIT noob. Unfortunately my available time for reading instructions will not allow me to do much better soon. I clicked your link and I see a pull request in the main cms repo.
Thanks a lot!
Thanks I have just did the other part. Now Brian takes a look and give us feedback so we can take the next steps.
@StefanSTS please mark your Test as successfully: