[#21968] - [4.0] Implement the workflow into the multilang sample data
- Closed
- 10 Sep 2018
- Medium
- Build: 4.0-dev
- # 21968
- Diff
- bembelimen:workflow-sample-data-multi
User tests: Successful: Unsuccessful:
Pull Request for Issue #21707 . (second part)
Summary of Changes
This PR let the multilang sample data creating a new Workflow to ensure, that the articles are published
Testing Instructions
- Install a 2nd language
- Apply the "Multilingual Sample Data" (from the dashboard)
- check the workflows, a new workflow called "Sample Workflow (xx-xx)" is created and assigned to the specific new sample data category (xx-xx is the language tag).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Labels |
Added:
?
?
|
||
Category created but showing no articles
Workflows created but only with one stage and no transitions
Articles not listed but do exist in the db
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21968.
In fact (not taking into account the transitions which should be the same as Joomla default imho), is missing the article set in _workflows_associations.
In my POC I had added in private function addArticle($itemLanguage, $categoryId)
+ $query->clear()
+ ->insert($db->qn('#__workflow_associations'))
+ ->values($newId . ', 2,' . $db->quote('com_content'));
+
+ $db->setQuery($query);
+
+ try
+ {
+ $db->execute();
+ }
+ catch (JDatabaseExceptionExecuting $e)
+ {
+ $this->setError($e->getMessage());
+
return false;
}
In this case with this new workflow, the value has to change in
->values($newId . ', 2,' . $db->quote('com_content')); if I do not mistake.
I do not see the reason to create a specific workflow per language btw.
Call it what you want but it can be generic for all content languages, imho.
The last commit did not go through last night..... I recommited it, should be fixed now.
This corrects now the status of articles. Tks.
Remains the fact that the new workflow do not have the same stages than joomla default and that it looks overkill to create a workflow per language.
Simple is better. Call it "Sample Multilingual Workflow" and out the foreach. :)
I have tested this item
Tested successfully with de-DE and en-GB. All data found as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21968.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21968.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Please be nice to drone. Param $itemlanguage is no more. :)
FILE: ...github.com/joomla/joomla-cms/plugins/sampledata/multilang/multilang.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
987 | ERROR | Superfluous doc comment at position 1
@bembelimen
Please correct drone
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-10 13:52:45 |
| Closed_By | ⇒ | bembelimen |
@bembelimen Why was this closed?
Can you update this please
PLG_SAMPLEDATA_MULTILANG_STEP6_SUCCESS