? Pending

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
29 Aug 2018

Summary of Changes

https://codemirror.net/doc/releases.html

A couple of versions were skipped. Previous version in Joomla was 5.38.0

Testing Instructions

Use CodeMirror.

Expected result

It shall work as usual.

Actual result

It is fine.

Documentation Changes Required

Nope.


Also of interest to CodeMirror users (although not related to this PR at all): https://codemirror.net/6/

avatar okonomiyaki3000 okonomiyaki3000 - open - 29 Aug 2018
avatar okonomiyaki3000 okonomiyaki3000 - change - 29 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2018
Category JavaScript External Library
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Aug 2018

I have tested this item successfully on 46a70a4

System information

  • 3.8.13-dev
  • Template: Protostar
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Aug 2018 - Tested successfully
avatar okonomiyaki3000
okonomiyaki3000 - comment - 29 Aug 2018

Looks like drone couldn't run npm install. Surely unrelated to this PR. Can it be switched to using yarn instead of npm? Yarn works for me in a lot of cases where npm has trouble.

avatar brianteeman
brianteeman - comment - 29 Aug 2018

I have tested this item successfully on 46a70a4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21902.

avatar brianteeman brianteeman - test_item - 29 Aug 2018 - Tested successfully
avatar mbabker mbabker - change - 29 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-29 12:30:32
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Aug 2018
avatar mbabker mbabker - merge - 29 Aug 2018

Add a Comment

Login with GitHub to post a comment