? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
26 Aug 2018

Make sure an copied repo don't run into issues with the rips step

cc @rdeutz @wilsonge

avatar zero-24 zero-24 - open - 26 Aug 2018
avatar zero-24 zero-24 - change - 26 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2018
Category Unit Tests
avatar zero-24 zero-24 - change - 26 Aug 2018
The description was changed
avatar zero-24 zero-24 - edited - 26 Aug 2018
avatar rdeutz
rdeutz - comment - 1 Sep 2018

I think there is a better way, @zero-24 can you have a look at this http://docs.drone.io/step-conditions/ We can limit steps based on the branch the build is running. So it is clearer what we are doing

avatar zero-24
zero-24 - comment - 2 Sep 2018

Well i'm more thinking about 1:1 copys of the cms repos like the privacy repo or all the other 4.0-dev clones out there like the gsoc repos. As far as I understand the branch etc would not help us here? It could help with the different app id's for sure.

avatar zero-24 zero-24 - change - 4 Sep 2018
Labels Added: ? ?
avatar zero-24 zero-24 - change - 4 Sep 2018
Title
[Drone] Make sure an copied repo don't run into issues with the reps step
[Drone] Make sure an copied repo don't run into issues with the rips step
avatar zero-24 zero-24 - edited - 4 Sep 2018
avatar zero-24 zero-24 - change - 4 Sep 2018
Title
[Drone] Make sure an copied repo don't run into issues with the rips step
[Drone] Make sure an copied repo don't run into issues with the rips step & add tests for 4.0-dev
avatar zero-24 zero-24 - edited - 4 Sep 2018
avatar zero-24
zero-24 - comment - 4 Sep 2018

@rdeutz this is now fully working and all tests (rips 4.0-dev & staging) are in an single file now. When approved we can merge the .drone.yml up to the other branches so we don't mess up the config at the time Michael or George do branch merges. ;)

avatar rdeutz rdeutz - change - 5 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-05 06:39:07
Closed_By rdeutz
avatar rdeutz rdeutz - close - 5 Sep 2018
avatar rdeutz rdeutz - merge - 5 Sep 2018
avatar rdeutz
rdeutz - comment - 5 Sep 2018

I will copy the change into the 4.0-dev branch

avatar zero-24
zero-24 - comment - 5 Sep 2018

Thanks @rdeutz

Add a Comment

Login with GitHub to post a comment