? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
26 Aug 2018

Pull Request for Issue
#21847 .

Summary of Changes

Modals should be placed before </body> tag.

Testing Instructions

Apply patch, check the batch operation on article list view

Expected result

Actual result

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 26 Aug 2018
avatar dgrammatiko dgrammatiko - change - 26 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2018
Category Libraries
0801563 26 Aug 2018 avatar dgrammatiko cs
avatar dgrammatiko dgrammatiko - change - 26 Aug 2018
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Aug 2018

check the batch operation on article list view

what to look for?

avatar dgrammatiko
dgrammatiko - comment - 26 Aug 2018

@franz-wohlkoenig check the issue: #19408

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Aug 2018

Batch operation on article list view works as expected without this PR.

"Fetch Data" in Patchtester works as expected with this PR.

Thats why i was asking.

avatar bembelimen
bembelimen - comment - 26 Aug 2018

With this changes you break all structures regarding CSS.

Before you could add the modal code into your extension with a specific "wrapper class" to format e.g. the content of all modals.

Now the modal is never into the extension again.

avatar ghazal
ghazal - comment - 26 Aug 2018

I am a bit at a loss here.
#21847 and this one work alright.
But,

With this changes you break all structures regarding CSS

@bembelimen
Where do we have to check ?

avatar dgrammatiko
dgrammatiko - comment - 26 Aug 2018

Before you could add the modal code into your extension with a specific "wrapper class" to format e.g. the content of all modals.

You can still do that now. All modals have an id so in your layout css you could target the modal contents through that selector

avatar bembelimen
bembelimen - comment - 26 Aug 2018

Yes and no, if you create modals on the fly, you don't know the ID for the CSS file.

avatar dgrammatiko
dgrammatiko - comment - 26 Aug 2018

Yes and no, if you create modals on the fly, you don't know the ID for the CSS file.

That's not a problem. You either have a pattern creating the id (eg article_modal_ + artcleId) or you prepend something random and then you take care css in JS.
BTW this is actually something that we need one way or another as the modals will be dialog tags and the polyfill suggests that all elements should be before the closing body tag. So that was the plan from the beginning, if you have code that depends on specific position of the modals you need to do the adjustments (this is also the case for couple instances in core as well).

avatar brianteeman brianteeman - change - 26 Aug 2018
Title
[4.0] render modals cosinstently
[4.0] render modals consistently
avatar brianteeman brianteeman - edited - 26 Aug 2018
avatar FPerisa
FPerisa - comment - 28 Aug 2018

I have tested this item successfully on 0801563

With the patch the patchtesters modal is working again.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21852.

avatar FPerisa FPerisa - test_item - 28 Aug 2018 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 29 Aug 2018

#21847 is a better fit for the project

avatar dgrammatiko dgrammatiko - change - 29 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-29 10:25:06
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 29 Aug 2018

Add a Comment

Login with GitHub to post a comment