Feeling Lucky
?
[#21791] - [4.0] Missing &
- Fixed in Code Base
- 21 Aug 2018
- Medium
- Build: 4.0-dev
- # 21791
- Diff
- brianteeman:session-token
User tests: Successful: Unsuccessful:
Fixes an obvious error that the Session::getFormToken() was being appended to the previous item instead of being prepended with an &
Note that there are still a large number of form actions without Session::getFormToken()
If someone can confirm that they should always have Session::getFormToken() then I will update those as well
Testing
Code review only
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_menus com_modules com_newsfeeds com_plugins com_tags com_workflow |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-21 10:40:28 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 21 Aug 2018
OK - understood. So another PR will be incoming shortly for all the ajax ones that dont have a token
It depends on the form action. If it submits the form it's via the form token
joomla-cms/administrator/components/com_categories/tmpl/categories/default.php
Line 286 in bc5ba76