? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
21 Aug 2018

Moves the manifest files of com_wrapper and com_mailto to the back end.

avatar laoneo laoneo - open - 21 Aug 2018
avatar laoneo laoneo - change - 21 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2018
Category Administration
avatar brianteeman
brianteeman - comment - 21 Aug 2018

can you update the files so that they are correct

avatar laoneo
laoneo - comment - 21 Aug 2018

What update?

avatar brianteeman
brianteeman - comment - 21 Aug 2018

The files in the admin folder section

avatar laoneo
laoneo - comment - 21 Aug 2018

Guess I need to do that then for all files as I completely forgot to update the manifest files with the new files from all the service changes. Will do that then in another pr.

avatar brianteeman
brianteeman - comment - 21 Aug 2018

OK - just did a quick sample test and they are all outdated

avatar mbabker
mbabker - comment - 21 Aug 2018

Should not be merged until a decision on #18246 is made.

avatar laoneo
laoneo - comment - 21 Aug 2018

Actually this pr fixes the discrepancy in core that every component needs an administrator folder ?

avatar laoneo
laoneo - comment - 9 Sep 2018

So can this being merged then?

avatar mbabker mbabker - change - 9 Sep 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-09-09 17:06:50
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 9 Sep 2018
avatar mbabker mbabker - merge - 9 Sep 2018
avatar wilsonge
wilsonge - comment - 11 Sep 2018

This has broken the installer

<br />
<b>Warning</b>:  simplexml_load_file(): I/O warning : failed to load external entity &quot;/Users/george/Sites/joomla-cms/components/com_mailto/mailto.xml&quot; in <b>/Users/george/Sites/joomla-cms/libraries/src/Installer/Installer.php</b> on line <b>2032</b><br />
<br />
<b>Warning</b>:  simplexml_load_file(): I/O warning : failed to load external entity &quot;/Users/george/Sites/joomla-cms/components/com_wrapper/wrapper.xml&quot; in <b>/Users/george/Sites/joomla-cms/libraries/src/Installer/Installer.php</b> on line <b>2032</b><br />
avatar wilsonge
wilsonge - comment - 11 Sep 2018

Fixed with 024d943

avatar brianteeman
brianteeman - comment - 11 Sep 2018

Don't you need to create update SQL as well?

avatar alikon
alikon - comment - 11 Sep 2018

plus
last time i've tryed to run 4.x on postgresql
postgres@joomla WARNING: nonstandard use of \\ in a string literal at character 113 [16147] postgres@joomla HINT: Use the escape string syntax for backslashes, e.g., E'\\'.

should we take care about namespacing ? ... more

avatar alikon
alikon - comment - 11 Sep 2018

ops pgsql

avatar wilsonge
wilsonge - comment - 11 Sep 2018

@laoneo please can you sort out the update SQL tomorrow

avatar laoneo
laoneo - comment - 12 Sep 2018

Pr with update scripts #22138.

Add a Comment

Login with GitHub to post a comment