[#21697] - [4.0] FIX batch categories modal layout as well as batch-language js files
- Fixed in Code Base
- 19 Aug 2018
- Medium
- Build: 4.0-dev
- # 21697
- Diff
- infograf768:4.0_categories_batch_plus
User tests: Successful: Unsuccessful:
Pull Request for Issue #21473
Also corrects js #21685 (Thanks @dgrammatiko)
Summary of Changes
Corrected and moved the batch-language js files to the right folder to be able to load them
Corrected display of default-batch-body. php for categories.
Added loading the js in the batch item layout file.
Testing Instructions
Select a category. Click on Batch.
Before batch
The layout is badly wrong.
Choosing or not a category to move or copy does not show/hide the Move/Copy buttons
After patch
Layout may still need some work but now it is usable.
THAT aspect CAN be tested by patchtester users.
Move Copy category now displays the show Move buttons fine.
NOT for patchtester users!
Note
We need to correct other default-batch-body.php
Will do after this is merged.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories JavaScript Repository Layout |
| Labels |
Added:
?
|
||
@infograf768 the path for the es6.js file should be build/media_src/layouts/joomla/html/batch/js/batch-language.es6.js not
build/media_src/layouts/js/joomla/html/batch/batch-language.es6.js
@dgrammatiko
testing here if changing the place for the js folder is fine
@dgrammatiko
changing path as you propose breaks loading the js file with HTMLHelper
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21697.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21697.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-19 09:01:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on aba9362
Test using Patchtester.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21697.