Feeling Lucky
?
[#21606] - [4.0] Webcomponent tab.js typo
- Fixed in Code Base
- 14 Aug 2018
- Medium
- Build: 4.0-dev
- # 21606
- Diff
- brianteeman:orientation
User tests: Successful: Unsuccessful:
oriendation ==> orientation
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-14 10:06:00 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
dgrammatiko
- comment
- 14 Aug 2018
@brianteeman @wilsonge actually that file is not being used. The code in use is from the other repo
wilsonge
- comment
- 14 Aug 2018
Then please do a PR to delete the file.... we can't have unused duplicates everywhere
brianteeman
- comment
- 14 Aug 2018
Please do - and fix the typo in the other repo
dgrammatiko
- comment
- 14 Aug 2018
@brianteeman if you're gonna fix this please do it in the panels script not the tabs. Tabs is the old script, not a11y 100%
wilsonge
- comment
- 14 Aug 2018
Patched typo in custom elements repo joomla-projects/custom-elements@fac7caa (panels was already fixed/fine).
wilsonge
- comment
- 14 Aug 2018
@dgrammatiko can you do the PR to remove tabs from this repo then please
wilsonge
- comment
- 14 Aug 2018
Thanks :)
Thanks!