Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21559] - [4.0] [a11y] Rules permissions - text filters notes

? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
11 Aug 2018

I am not sure what the logic/reasoning was for putting the notes on the permissions tab inside a custom element "joomla-alert" but it was wrong - it is not an alert it is just information. Making it an alert has significant impact.

This custom element adds role="alert" to the container. In a11y this role=alert is equivalent to using aria-live=assertive. aria-live="assertive" should be used only when you think the user needs to know the information the very second it appears.

So what happens is that as soon as the permissions tab gets focus and before anything else can happen the entire content of the alert is announced (and cannot be interrupted because it is so important).

This PR changes it back to a simple div and adds some simple css - which obviously can be changed and improved upon.

[update]

Also added the text-filter notes at the bottom of the page to this PR as its basically the exact same problem

(can be tested with patchtester)

avatar brianteeman brianteeman - open - 11 Aug 2018
avatar brianteeman brianteeman - change - 11 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Aug 2018
Category ⇒ Administration Templates (admin) Layout
8accf6d 11 Aug 2018 avatar brianteeman hound
avatar brianteeman brianteeman - change - 11 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2018
Category Administration Templates (admin) Layout ⇒ Administration com_config Templates (admin) Layout
avatar brianteeman brianteeman - change - 14 Aug 2018
Title
…
[4.0] [a11y] Rules permissions
[4.0] [a11y] Rules permissions - text filters notes
avatar brianteeman brianteeman - edited - 14 Aug 2018
avatar brianteeman brianteeman - change - 14 Aug 2018
The description was changed
avatar brianteeman brianteeman - edited - 14 Aug 2018
avatar brianteeman brianteeman - change - 14 Aug 2018
The description was changed
avatar brianteeman brianteeman - edited - 14 Aug 2018
avatar brianteeman
brianteeman - comment - 24 Aug 2018

Conflicts resolved

avatar wojsmol
wojsmol - comment - 2 Sep 2018

I have tested this item ✅ successfully on e6ff344

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21559.

avatar wojsmol
wojsmol - comment - 2 Sep 2018

I have tested this item ✅ successfully on e6ff344

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21559.

avatar wojsmol wojsmol - test_item - 2 Sep 2018 - Tested successfully
avatar zwiastunsw
zwiastunsw - comment - 2 Sep 2018

I have tested this item ✅ successfully on e6ff344

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21559.

avatar zwiastunsw zwiastunsw - test_item - 2 Sep 2018 - Tested successfully
avatar Quy Quy - change - 3 Sep 2018
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 3 Sep 2018

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21559.

avatar laoneo laoneo - change - 3 Sep 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-09-03 05:04:44
Closed_By ⇒ laoneo
Labels Added: ?
avatar laoneo laoneo - close - 3 Sep 2018
avatar laoneo laoneo - merge - 3 Sep 2018
avatar laoneo
laoneo - comment - 3 Sep 2018

Thanks

avatar brianteeman
brianteeman - comment - 3 Sep 2018

Thanks

Add a Comment

Login with GitHub to post a comment