[#21558] - [4.0] allow jdoc:include type=message to load assets
- Fixed in Code Base
- 15 Aug 2018
- Medium
- Build: 4.0-dev
- # 21558
- Diff
- dgrammatiko:document/4.0-dev/renderer
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The alerts custom element assets are repeatedly inserted in too many pages. We can do better than that, by treating the<jdoc:include type="message" /> the same way we treat modules.
Testing Instructions
Check that alerts are rendering correctly
Expected result
Actual result
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Layout Libraries Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21558.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have tested this item
enqueueMessage in a module is not working anymore
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21558.
| Status | Ready to Commit | ⇒ | Pending |
Status back on "Pending".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21558.
@laoneo @chrisdavenport I think now it works as expected
Looks correct now.
| Labels |
Added:
?
|
||
I have tested this item
Works also with modules
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21558.
@chrisdavenport can you please mark your Test as successfully?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-15 05:17:17 |
| Closed_By | ⇒ | laoneo |
Thanks!
@franz-wohlkoenig I didn't test it, I only looked at the code.
I have tested this item✅ successfully on 02716bb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21558.