[#21426] - [4.0] Take results outside the form tag in Archives page
- Fixed in Code Base
- 21 Sep 2018
- Medium
- Build: 4.0-dev
- # 21426
- Diff
- htmgarcia:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue N/A .
Summary of Changes
Moving the archive results outside the form. There is no need to have the results inside the form.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
Hi @brianteeman,
the question here is: why do we have non required content inside the <form> tag? Is about best practices.
And yes! The filtering and pagination still works.
Thats good to hear - I couldn't test it as there is a syntax error in the file with if opened on l19 but not closed
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21426.
Hi @htmgarcia, I want to test your changes, but I need more information on how to test it. Could you please add testing instructions? Thank you.
I have tested this item
Result as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21426.
@christianhent can you please describe how you have tested so @lavipr can also test?
@lavipr there are no visual improvements when testing this PR, just a better HTML code in the source as described at the beginning:
Moving the archive results outside the form. There is no need to have the results inside the form.
Not sure how to provide you testing instructions besides updating the file I modified in a local Joomla 4 installation.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21426.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21426.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-09-21 06:57:07 |
| Closed_By | ⇒ | laoneo |
Thanks
Are you sure? Does pagination and the special archive filtering still works?