? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Aug 2018

PR for #21401

Thanks for the code @infograf768

avatar brianteeman brianteeman - open - 6 Aug 2018
avatar brianteeman brianteeman - change - 6 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2018
Category Administration Templates (admin)
avatar brianteeman brianteeman - change - 6 Aug 2018
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 6 Aug 2018 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Aug 2018

I have tested this item ? unsuccessfully on 704fd7e

Same Result on /administrator/index.php?option=com_config&view=component&component=com_media as without PR.

screen shot 2018-08-06 at 20 23 05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21425.
avatar brianteeman
brianteeman - comment - 6 Aug 2018

closed while i fix the build

avatar brianteeman brianteeman - change - 6 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-06 18:34:41
Closed_By brianteeman
avatar brianteeman brianteeman - close - 6 Aug 2018
avatar brianteeman
brianteeman - comment - 6 Aug 2018

It looks correct so I have no idea why its not working - hopefully someone can see the error

avatar brianteeman brianteeman - change - 6 Aug 2018
Status Closed New
Closed_Date 2018-08-06 18:34:41
Closed_By brianteeman
avatar brianteeman brianteeman - change - 6 Aug 2018
Status New Pending
avatar brianteeman brianteeman - reopen - 6 Aug 2018
avatar brianteeman
brianteeman - comment - 6 Aug 2018

updated now

avatar ggppdk
ggppdk - comment - 6 Aug 2018

It works, but same need in menu items

what about fixing this for all screens by adding to
template.scss
template-rtl.scss

or to other appropriate scss file ?

.control-group {
	&.field-spacer {
		.control-label {
			width: auto;
		}
	}
}
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Aug 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Aug 2018

I have tested this item successfully on 3954198


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21425.

avatar infograf768
infograf768 - comment - 7 Aug 2018

Agree with @ggppdk
The fix should be done as a general fix not as a specific com_config one.

For the moment the issue is only present in 2 places, but it may be necessary elsewhere too in the future.

avatar ggppdk
ggppdk - comment - 7 Aug 2018

hhmm in more than 2 places ...

Searching for (type="spacer" that also has label)

Search "type="spacer"\s+label="" (24 hits in 17 files)

administrator\components\com_categories\forms\category.xml (1 hit)
	Line 126: 		type="spacer"

administrator\components\com_fields\forms\field.xml (1 hit)
	Line 102: 			type="spacer"

administrator\components\com_media\config.xml (1 hit)
	Line 27: 			type="spacer" 

components\com_contact\forms\contact.xml (1 hit)
	Line 6: 			type="spacer"

components\com_contact\tmpl\categories\default.xml (2 hits)
	Line 97: 				type="spacer" 
	Line 187: 				type="spacer" 

components\com_contact\tmpl\category\default.xml (2 hits)
	Line 40: 				type="spacer" 
	Line 132: 				type="spacer" 

components\com_contact\tmpl\featured\default.xml (1 hit)
	Line 22: 				type="spacer" 

components\com_content\tmpl\categories\default.xml (3 hits)
	Line 101: 				type="spacer" 
	Line 201: 				type="spacer"
	Line 315: 				type="spacer" 

components\com_content\tmpl\category\blog.xml (1 hit)
	Line 173: 					type="spacer"

components\com_content\tmpl\featured\default.xml (1 hit)
	Line 35: 				type="spacer" 

components\com_newsfeeds\tmpl\categories\default.xml (2 hits)
	Line 100: 				type="spacer" 
	Line 192: 				type="spacer" 

components\com_newsfeeds\tmpl\category\default.xml (2 hits)
	Line 38: 			type="spacer" 
	Line 128: 				type="spacer" 

components\com_search\tmpl\search\default.xml (1 hit)
	Line 64: 				type="spacer"

components\com_tags\tmpl\tag\default.xml (1 hit)
	Line 130: 				type="spacer" 

components\com_tags\tmpl\tag\list.xml (1 hit)
	Line 129: 				type="spacer" 

components\com_users\forms\registration.xml (1 hit)
	Line 6: 			type="spacer"

plugins\user\profile\profile.xml (2 hits)
	Line 26: 					type="spacer"
	Line 169: 					type="spacer"
avatar brianteeman
brianteeman - comment - 7 Aug 2018

@ggppdk My quick check of a sample of the items you link to is that in all cases they are using the spacer for a title as intended and not for a long description which is what this pr addresses

avatar ggppdk
ggppdk - comment - 7 Aug 2018

@brianteeman

My quick check of a sample of the items you link to is that in all cases they are using the spacer for a title as intended and not for a long description which is what this pr addresses

i understand that for majority of case it is as you say, but not for all cases
e.g. create a menu item "Featured contents",
and go to 2nd TAB "List layouts", it is description

Is there any harm / reason not to fix this for all cases ?
adding to appropriate scss file ?

.control-group {
	&.field-spacer {
		.control-label {
			width: auto;
		}
	}
}
avatar brianteeman
brianteeman - comment - 7 Aug 2018

dont have time to debate that the spacer field is being abused - feel free to submit your own pr

avatar brianteeman brianteeman - close - 7 Aug 2018
avatar brianteeman brianteeman - change - 7 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-07 09:38:41
Closed_By brianteeman
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Aug 2018

Issue #21401 reopened.

avatar brianteeman brianteeman - change - 19 Aug 2018
Status Closed New
Closed_Date 2018-08-07 09:38:41
Closed_By brianteeman
avatar brianteeman brianteeman - change - 19 Aug 2018
Status New Pending
avatar brianteeman brianteeman - reopen - 19 Aug 2018
avatar brianteeman brianteeman - change - 19 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-19 14:51:53
Closed_By brianteeman
avatar brianteeman brianteeman - close - 19 Aug 2018

Add a Comment

Login with GitHub to post a comment