User tests: Successful: Unsuccessful:
PR for #21401
Thanks for the code @infograf768
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Labels |
Added:
?
|
closed while i fix the build
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-06 18:34:41 |
Closed_By | ⇒ | brianteeman |
It looks correct so I have no idea why its not working - hopefully someone can see the error
Status | Closed | ⇒ | New |
Closed_Date | 2018-08-06 18:34:41 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Status | New | ⇒ | Pending |
updated now
It works, but same need in menu items
what about fixing this for all screens by adding to
template.scss
template-rtl.scss
or to other appropriate scss file ?
.control-group {
&.field-spacer {
.control-label {
width: auto;
}
}
}
I have tested this item
hhmm in more than 2 places ...
Searching for (type="spacer" that also has label)
Search "type="spacer"\s+label="" (24 hits in 17 files)
administrator\components\com_categories\forms\category.xml (1 hit)
Line 126: type="spacer"
administrator\components\com_fields\forms\field.xml (1 hit)
Line 102: type="spacer"
administrator\components\com_media\config.xml (1 hit)
Line 27: type="spacer"
components\com_contact\forms\contact.xml (1 hit)
Line 6: type="spacer"
components\com_contact\tmpl\categories\default.xml (2 hits)
Line 97: type="spacer"
Line 187: type="spacer"
components\com_contact\tmpl\category\default.xml (2 hits)
Line 40: type="spacer"
Line 132: type="spacer"
components\com_contact\tmpl\featured\default.xml (1 hit)
Line 22: type="spacer"
components\com_content\tmpl\categories\default.xml (3 hits)
Line 101: type="spacer"
Line 201: type="spacer"
Line 315: type="spacer"
components\com_content\tmpl\category\blog.xml (1 hit)
Line 173: type="spacer"
components\com_content\tmpl\featured\default.xml (1 hit)
Line 35: type="spacer"
components\com_newsfeeds\tmpl\categories\default.xml (2 hits)
Line 100: type="spacer"
Line 192: type="spacer"
components\com_newsfeeds\tmpl\category\default.xml (2 hits)
Line 38: type="spacer"
Line 128: type="spacer"
components\com_search\tmpl\search\default.xml (1 hit)
Line 64: type="spacer"
components\com_tags\tmpl\tag\default.xml (1 hit)
Line 130: type="spacer"
components\com_tags\tmpl\tag\list.xml (1 hit)
Line 129: type="spacer"
components\com_users\forms\registration.xml (1 hit)
Line 6: type="spacer"
plugins\user\profile\profile.xml (2 hits)
Line 26: type="spacer"
Line 169: type="spacer"
My quick check of a sample of the items you link to is that in all cases they are using the spacer for a title as intended and not for a long description which is what this pr addresses
i understand that for majority of case it is as you say, but not for all cases
e.g. create a menu item "Featured contents",
and go to 2nd TAB "List layouts", it is description
Is there any harm / reason not to fix this for all cases ?
adding to appropriate scss file ?
.control-group {
&.field-spacer {
.control-label {
width: auto;
}
}
}
dont have time to debate that the spacer field is being abused - feel free to submit your own pr
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-07 09:38:41 |
Closed_By | ⇒ | brianteeman |
Status | Closed | ⇒ | New |
Closed_Date | 2018-08-07 09:38:41 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Status | New | ⇒ | Pending |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-19 14:51:53 |
Closed_By | ⇒ | brianteeman |
I have tested this item? unsuccessfully on 704fd7e
Same Result on /administrator/index.php?option=com_config&view=component&component=com_media as without PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21425.