? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
4 Aug 2018

Pull Request for Issue # .

Summary of Changes

This PR converts the core.js and keepalive.js to ES6

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 4 Aug 2018
avatar dgrammatiko dgrammatiko - change - 4 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2018
Category JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 4 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2018
Category JavaScript Repository Administration com_contact com_content com_contenthistory com_messages com_redirect JavaScript Repository Layout Libraries
215af3b 8 Aug 2018 avatar dgrammatiko CS
avatar dgrammatiko
dgrammatiko - comment - 8 Aug 2018

The last commit fixes some stupid bug in multiselct.js (thanks @infograf768 for finding this) and converts keepalive.js to pure functions (as pure as they can be).
Why?
setinterval() is a closure and thus in ES6 the lexical is lost (eg keepAliveUrl)...
That's the reaso that the acutal function that calls Joomla.request also assigns local variables for the URL:

const keepAliveOptions = Joomla.getOptions('system.keepalive');

@wilsonge

avatar wilsonge wilsonge - close - 8 Aug 2018
avatar wilsonge wilsonge - merge - 8 Aug 2018
avatar wilsonge wilsonge - change - 8 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-08 12:11:58
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment