NOTE for people testing such PR.
If you do not use a local git repo and do not run composer install and npm install, fetch nightly build and Install patchtester.

EDIT: can't use patchtester for that kind of PR...

Patchtester cannot be used here to test this pr :(

Oh.
Then let's merge it.
@laoneo
@wilsonge

@dgrammatiko is right - at leasts node.js is required.

I have tested this item ? unsuccessfully on dc9f0f8

Using Patch get same count of Notices as without Patch.

I have tested this item ? unsuccessfully on dc9f0f8

Using Patch get same count of Notices as without Patch.

I have not tested this item.

@franz-wohlkoenig

Indeed you can't test as the min.js and .js have to get in via using node.
Basically the new files which are used are in the media folder after this PR is merged and node is used to create the new files.
This is going to be a real issue...

@infograf768 this is not a Problem as i can revert the Test. But it would save Time if PR-Dev. write "not testable in Patchtester".

@franz-wohlkoenig are you using glip? If yes I will try to help you with node.js and composer installation.

This is going to be a real issue...

Then let's find someone with some spare time to publish this: https://github.com/joomla-projects/gsoc17_pr_testing_platform

To be clear, patch tester has always been a convenience tool. It was never designed to be the official patch testing mechanism, and can never be because to properly apply and rollback patches requires data not available within a regular CMS install (and if you do have that data available the odds are you don't need patch tester to begin with).

Truth be told, I'm pretty close to just breaking 4.0 compatibility within it. Because 4.0 is a moving target and with the changes made this week essentially the component is useless on that version.

I will make time this weekend to work out an issue tracker level integration where you can download a packaged Joomla build for testing a pull request since it seems getting the PR testing platform to a usable state has stagnated.

@wojsmol i'm using Glip and thanks for your Offer. But its no Problem if i can't test an PR, most of them (so far) i can test using Patchtester.

@mbabker is this the "testing platform" you are referring to https://github.com/joomla-projects/gsoc17_pr_testing_platform ? If so it's not been touched for a year

Yep. A couple months ago the team was given the keys to a server to get that set up on our hosting architecture for use, that's the last update I have on things.

@franz-wohlkoenig Just wrote and I will give you my invitation link. :)

@infograf768 this is not a Problem as i can revert the Test. But it would save Time if PR-Dev. write "not testable in Patchtester".

I will definitely do that for any future PR.

I kow most people don't like the command line but here is an option to test such a PR, we have a docker container we are using in our testing environment to install dependencies. You can use this one (when you have docker installed on your computer) to setup a testing environment. You still need a local webserver and a Database.

Start the container

docker run -it --rm -v $(pwd):/opt -w /opt joomlaprojects/docker-tools bash

Any command you execute from now on is runnig in the container

git clone --single-branch -b 4.0-dev https://github.com/joomla/joomla-cms.git
cd joomla-cms
composer install
npm i

Now you have a actual joomla-4.0 dev version of joomla with all files you need

Next step is to get the PR Data
git fetch origin pull/21362/head:local_pr_21362

and update all files
npm run update

Done you can now start testing (after you installed Joomla!)

ctrl + c to exit the container but you can also let it run, you might will update or test a different PR

@franz-wohlkoenig If ? mean you wont the link then here it is https://glip.com/invite/c7ad743 - this is from my private glip outside joomla.org teams

@rdeutz as an option for people who don't like the cli that's probably a more scarey solution than we currently have :)

@wojsmol Link open "Bug Squad Public Discussion". ? means Thank for your Offer, but Patchtester (or similar) is my Level.

its just an option, I think it is far easier as install git, php and node locally

@rdeutz for example @franz-wohlkoenig AFAIK have local server then only node and composer bare missing on his Mac. The have is true for me on Windows but I have already installed missing thing.

as I said it is an option, I am not pushing people to one or another

@wojsmol
As you know your npm, can you test this PR?
I know it works, but it really would be good to merge it now.

@infograf768 If you don't have issue fact that I must apply the additionally PR #21371.

I do not have here the issue you describe in #21371

This iS reproachable at lest on Windows and Firefox 61.0.1 (64 bits).

I have tested this item ? unsuccessfully on dc9f0f8

Using Patch get same count of Notices as without Patch.

Please ignore Test as for now Front- and Backend-PRs are able to test by Patchtester.

I have not tested this item.

For the people who do not use npm, here are the 2 files created by npm for this PR so you can test.

they should replace their equivalent in media/com_associations/js/

associations-edit.js.zip

I have tested this item ✅ successfully on dc9f0f8

Thanks JM!