User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Missed the commands in the package.json
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
can confirm this fixes the missing commands
I have tested this item
These now finish
npm run build:css
npm run build:js
And these continue to work
npm install
node build.js --compile-css
node build.js --compile-js
Category | ⇒ | CLI |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
npm run build:css
returns
something exploded 1
something exploded Invalid CSS after "...eed to override": expected 1 selector or at-rule, was "text-rendering: aut"
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 31
something exploded Undefined variable: "$input-btn-padding-y".
something exploded 3
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129
npm install is working
Yes I get that too but that's not what this issue was fixing
I have tested this item
@dgrammatiko I now running npm run build:css redirected to log file - give me a moment.
@dgrammatiko log send from my gmail e-mail adress.
Labels |
Added:
?
|
Category | CLI | ⇒ | JavaScript Repository |
tested on b496bdd results
something exploded 1
something exploded Invalid CSS after "...eed to override": expected 1 selector or at-rule, was "text-rendering: aut"
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 31
something exploded Undefined variable: "$input-btn-padding-y".
something exploded 3
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129
can I have the log created there (not the terminal output)
log send via mail
On windows 10
There seems to be a problem with new line endings
with file
media\vendor\font-awesome\scss_mixins.scss
this can not be right ?
a lot of wrong stuff in the same line , the syntax is broken
// Mixins // -------------------------- @mixin fa-icon(){display:inline-block;font:normal normal normal #{$fa-font-size-base}/#{$fa-line-height-base}FontAwesome;// shortening font declaration font-size:inherit;// can't have font-size inherit on line above, so need to override
text-rendering: auto; // optimizelegibility throws things off #1094
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
Also same problem with line endings with file,
\media\vendor\bootstrap\scss\_root.scss
comments and code everything in 1 line
and other files
Good find.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-02 08:43:37 |
Closed_By | ⇒ | wilsonge |
Merging this as it solves the immediate test problems. But obviously still windows problems to fix in a further PR
@ggppdk can you try changing the default line ending as described here: https://stackoverflow.com/questions/2517190/how-do-i-force-git-to-use-lf-instead-of-crlf-under-windows/13154031#13154031
Does this work?
@dgrammatiko, i was thinking to look for a nodejs setting , but if these files are created from repository files thar are checked out by git, then your suggestion , makes sense, will try in the evening and post back, thanks
now
fails with