? ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
1 Aug 2018

Pull Request for Issue # .

Summary of Changes

Missed the commands in the package.json

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 1 Aug 2018
avatar dgrammatiko dgrammatiko - change - 1 Aug 2018
Status New Pending
avatar dgrammatiko dgrammatiko - change - 1 Aug 2018
Labels Added: ?
avatar ggppdk
ggppdk - comment - 1 Aug 2018

now

npm install

fails with

error: unknown option `--build-check'
avatar ggppdk
ggppdk - comment - 1 Aug 2018

We also need PR ?
#21331

[EDIT]
Maybe add this fix to PR #21331 ??

avatar dgrammatiko
dgrammatiko - comment - 1 Aug 2018

@ggppdk that was my bad
3f9143b
should fix it. Also applied the same fix in the other PR

avatar brianteeman
brianteeman - comment - 1 Aug 2018

can confirm this fixes the missing commands

avatar ggppdk ggppdk - test_item - 1 Aug 2018 - Tested successfully
avatar ggppdk
ggppdk - comment - 1 Aug 2018

I have tested this item successfully on 3f9143b

These now finish

npm run build:css
npm run build:js

And these continue to work

npm install
node build.js --compile-css
node build.js --compile-js

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21350.
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Aug 2018
Category CLI
avatar brianteeman brianteeman - test_item - 1 Aug 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Aug 2018

I have tested this item successfully on 3f9143b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21350.

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Aug 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Aug 2018

Ready to Commit after two successful tests.

avatar wojsmol
wojsmol - comment - 1 Aug 2018

npm run build:css
returns

something exploded 1
something exploded Invalid CSS after "...eed to override": expected 1 selector or at-rule, was "text-rendering: aut"
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 31
something exploded Undefined variable: "$input-btn-padding-y".
something exploded 3
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129

npm install is working

avatar brianteeman
brianteeman - comment - 1 Aug 2018

Yes I get that too but that's not what this issue was fixing

avatar wojsmol wojsmol - test_item - 1 Aug 2018 - Tested successfully
avatar wojsmol
wojsmol - comment - 1 Aug 2018

I have tested this item successfully on 3f9143b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21350.

avatar dgrammatiko
dgrammatiko - comment - 1 Aug 2018

@wojsmol can you send me the log file from that @ dgrammatiko at gmail com

I suspect that this is a win-dos problem but I need more info as I can not replicate it here:
screenshot 2018-08-01 at 19 51 38

avatar wojsmol
wojsmol - comment - 1 Aug 2018

@dgrammatiko I now running npm run build:css redirected to log file - give me a moment.

avatar wojsmol
wojsmol - comment - 1 Aug 2018

@dgrammatiko log send from my gmail e-mail adress.

avatar dgrammatiko dgrammatiko - change - 1 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2018
Category CLI JavaScript Repository
avatar dgrammatiko
dgrammatiko - comment - 1 Aug 2018

@wojsmol can you try this change?

avatar wojsmol
wojsmol - comment - 1 Aug 2018

tested on b496bdd results

something exploded 1
something exploded Invalid CSS after "...eed to override": expected 1 selector or at-rule, was "text-rendering: aut"
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 7
something exploded Invalid CSS after "...ly-monospace)}}": expected "}", was ""
something exploded 1
something exploded 31
something exploded Undefined variable: "$input-btn-padding-y".
something exploded 3
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129
something exploded 36
something exploded argument `$color` of `darken($color, $amount)` must be a color
something exploded 129
avatar dgrammatiko
dgrammatiko - comment - 1 Aug 2018

can I have the log created there (not the terminal output)

avatar wojsmol
wojsmol - comment - 1 Aug 2018

log send via mail

avatar ggppdk
ggppdk - comment - 1 Aug 2018

On windows 10

There seems to be a problem with new line endings
with file
media\vendor\font-awesome\scss_mixins.scss

this can not be right ?
a lot of wrong stuff in the same line , the syntax is broken

// Mixins // -------------------------- @mixin fa-icon(){display:inline-block;font:normal normal normal #{$fa-font-size-base}/#{$fa-line-height-base}FontAwesome;// shortening font declaration font-size:inherit;// can't have font-size inherit on line above, so need to override
  text-rendering: auto; // optimizelegibility throws things off #1094
  -webkit-font-smoothing: antialiased;
  -moz-osx-font-smoothing: grayscale;

}

Also same problem with line endings with file,
\media\vendor\bootstrap\scss\_root.scss
comments and code everything in 1 line

and other files

avatar brianteeman
brianteeman - comment - 1 Aug 2018

Good find.

avatar ggppdk
ggppdk - comment - 1 Aug 2018

And it seems i committed non-updated CSS files in this PR #21316 (when i resolved conflicts ?)
because i did them on ... windows ?

avatar wilsonge wilsonge - change - 2 Aug 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-02 08:43:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Aug 2018
avatar wilsonge wilsonge - merge - 2 Aug 2018
avatar wilsonge
wilsonge - comment - 2 Aug 2018

Merging this as it solves the immediate test problems. But obviously still windows problems to fix in a further PR

avatar dgrammatiko
dgrammatiko - comment - 2 Aug 2018
avatar ggppdk
ggppdk - comment - 2 Aug 2018

@dgrammatiko, i was thinking to look for a nodejs setting , but if these files are created from repository files thar are checked out by git, then your suggestion , makes sense, will try in the evening and post back, thanks

Add a Comment

Login with GitHub to post a comment