Feeling Lucky
?
?
[#21348] - [4.0] Fixed the parent item dropdown
- Fixed in Code Base
- 3 Aug 2018
- Medium
- Build: 4.0-dev
- # 21348
- Diff
- fatmaakay:21225-fix-menu-selection
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21225 .
Summary of Changes
Parent Item was always empty after changing the menu.
This PR fixes this problem.
Testing Instructions
- Click on system
- Click on global configuration
- Click on system
- Click on debug system to make it active
- Save and close
- Create a new menu.
- Open the menu item.
- Click on the menu.
- Check that the parent item is empty
- Apply patch
- Change the menu item again
- Check that the parent item is not empty
Expected result
Expected result is the parent item is not empty
Actual result
Actual result is parent item is empty
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
| Category | JavaScript | ⇒ | JavaScript Repository |
roland-d
- comment
- 2 Aug 2018
@infograf768 Could you test this as well please?
infograf768
- comment
- 3 Aug 2018
I have tested this item
Needs to use npm install as node build.js --compile-js is not enough here. (my test site contains #21204
But it works correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21348.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 3 Aug 2018
Setting this to RTC as it can't be tested by people not using npm...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21348.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-03 09:58:37 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on e75c3e3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21348.