[#21325] - [4.0] Article batch operation fixes
- Fixed in Code Base
- 2 Aug 2018
- Medium
- Build: 4.0-dev
- # 21325
- Diff
- jonasgonka:ArticleBatchOperationFixes
User tests: Successful: Unsuccessful:
Pull Request for Issue #21285.
Summary of Changes
Classes which were not defined but were in use became defined by a simple syntax changing. The namespaces had to be set global by putting a backslash before the classnames. Affected classes: JLoader, FieldsHelper
JEventDispatcher is deprecated, so the event has to be triggered by getting the main application from Factory.
Testing Instructions
Select an article clicking on the check box at the beginning of the line. Click on the "Batch"-button and select a category in the field below "To Move or Copy your selection please select a Category.". Check out any radio button and click "Process".
Documentation Changes Required
No changes required.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21325.
| Labels |
Added:
?
|
||
I have tested this item
Tested this successfully using the instructions provided on dc4d2b0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21325.
@brianteeman should this PR be tested after the latest changes from 4.0-dev are merged in this Branch or can it be tested and set RTC?
up to the person doing the merge to check that - they shouldnt be doing a blind merge anyway
I have tested this item
Doing Batch to another Category get:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21325.
@franz-wohlkoenig Your issue could be related to this issue #20136
@jonasgonka can you please mark your Test at Issue Tracker as unsuccessfully?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21325.
Like @Quy pointed out already, the error is caused by the code in line 280 in file ArticleMode.php
$this->createTagsHelper($this->tagsObserver, $this->type, $pk, $this->typeAlias, $this->table);
The function doesn't exist anymore in AdminModel. By comparing the usages of that createTagsHelper()-function in the fourth version with the third, I see that every usage has been removed in the fourth version (See ContactModel, CategoryModel, NewsfeedModel). I couldn't find any other function in replace. So I also would remove it. It seems not necessary for me. Would you agree?
I have tested this item
Sucessfully tested again with the new fixes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21325.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21325.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-02 11:15:44 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks
changed Title to show its about 4.0.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21325.