[#21324] - [4.0] Fixed the translation of the view type in menuitem
- Fixed in Code Base
- 1 Aug 2018
- Medium
- Build: staging
- # 21324
- Diff
- dieudonnetimma:fixed-the-translation-of-the-view-type-in-menuitem
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In the administration section of the menu component it is possible in the view "Manage all menuitems" to see all menu items. In this table we can see for each item in the column title: the title, the alias and the menu type. The problem was that the menu type was not translated before.
Testing Instructions
-Create a menuitem with a type
- go to the view "manage all menuitem"
Expected result
-The menutype of the menuitem is translated
Actual result
-The menutype of the menuitem is not translated
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin |
@brianteeman I noticed as well and relinked it against 4.0, now it is just 1 file. Thanks for noticing.
| Labels |
Added:
?
?
|
||
| Category | Unit Tests Repository Administration com_admin | ⇒ | Administration com_menus |
Definitely a bug. But won't this change then mean it won't work with 3pd components that have not been updated to this new file layout. IIRC both layouts will work
| Title |
|
||||||
Yes we need to do a series of if checks here - there's already one for the view folder (instead of views)
| Labels |
Added:
?
Removed: ? |
||
Code looks fine beside a minor CS issue.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-01 12:51:49 |
| Closed_By | ⇒ | wilsonge |
Nice stuff! Thanks!
You are trying to merge the Joomla 4 branch into staging (which won't work obviously)
If you only meant to make this change in Joomla 4 then you can edit this PR here on github by selecting the edit button next to the title and selecting 4.0-dev as the branch
If you meant to make this change in Joomla 3 then you will need to change the branch at your end and when updated push the changes