[#21309] - [3.9] modify installer to allow additional query params
- Fixed in Code Base
- 2 Aug 2018
- Medium
- Build: 3.9-dev
- # 21309
- Diff
- clayfreeman:3.9-dev
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Is your feature request related to a problem? Please describe.
Components are unable to specify additional query parameters when defining primary admin menu items in the manifest file. Submenu items, however, are able to specify additional query parameters.
Describe the solution you'd like
Patch this file to allow additional query parameters as specified in the component manifest, similar to how it is done for submenu items. See the changes in this pull request to apply the patch and test it.
Additional context
It should be possible to build components without the use of a "generic" controller that defines a default view. Menu items should be able to specify the task and view query parameters so that there is no ambiguity as to which controller and view class should be used.
Example
task and view can now be set in the primary menu item so that the default administration controller doesn't have to be used for the primary menu item.
<administration>
...
<menu task='test.display' view='test'>Test</menu>
...
</administration>For a component com_blah, the above code example will create a menu item that points to index.php?option=com_blah&task=test.display&view=test. This means that BlahControllerTest, BlahModelTest and BlahViewTest will be used to handle the request as opposed to the generic, component-wide BlahController and its BlahView$default_view class.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I'm not quite sure why the AppVeyor build failed; logically there was no difference from that merge commit.
Regardless, is there an update on this?
@clayfreeman next this PR needs two sucessfully Tests.
By Joomla developers or community members?
I have been running this patch for days with no issue.
On Jul 31, 2018, at 10:53 PM, Franz Wohlkönig notifications@github.com wrote:
@clayfreeman next this PR needs two sucessfully Tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Everyone can test (Test by PR-Creator doesn't count as its expected that he test before create Pull Request).
Edit: Its helpful to give Instructions for Tester in the PR, a Link to an Issue without Instructions isn't helpful to know what to test.
| Title |
|
||||||
Changed Title to show its about 3.9.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21309.
By Joomla developers or community members?
I have been running this patch for days with no issue.
All patches must be tested/reviewed by at least two people other than the person who submitted the pull request.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-02 22:30:19 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thankyou for your first contribution to the CMS!
I can see why you would want to allow task/view as you described in your issue (although don't feel strongly about it). However neither act nor sub are things used in core therefore I definitely am against them being magically whitelisted when they have no definition.