Feeling Lucky
?
[#21296] - [4.0] Speed up npm cli
- Fixed in Code Base
- 31 Jul 2018
- Medium
- Build: 4.0-dev
- # 21296
- Diff
- dgrammatiko:4.0-dev-boost-perf-for-npm-cli
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Reduces the impact of js uglification.
Some of the vendor files are not minified. We were running js uglification in every subdirectory of the media folder. This has a huge impact on performance.
Bench the npm i on a clean installation
Before: 80,69 sec
After: 59,24 sec
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
ggppdk
- comment
- 29 Jul 2018
I have tested this item
Works,
does not seem to cause problems
i can not code review this
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21296.
laoneo
- comment
- 30 Jul 2018
Conflicts
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-31 09:14:30 |
| Closed_By | ⇒ | wilsonge |
Another way to benchmark the changes here are our tests:
Before:
After:
That's almost 2 minutes difference or 25% improvement!!!