[#21287] - [4.0] Run a pre-check in app bootup to make sure dependencies are installed
- Fixed in Code Base
- 30 Jul 2018
- Medium
- Build: 4.0-dev
- # 21287
- Diff
- mbabker:build-step-check
User tests: Successful: Unsuccessful:
Pull Request for Issue #21278
Summary of Changes
Run a check during the application bootup to make sure that composer install and npm install are run (well, relatively sane checks at least).
This uses the same approach as the incompatible PHP version page as it relates to language strings, page design, etc. If you're reviewing and don't like the JavaScript, you don't like your own script because it's a copy of the PHP page logic
Testing Instructions
Try to run Joomla without the Composer autoloader (file libraries/vendor/autoload.php generated by composer install) or the media/vendor directory (created by npm install). You'll get a friendly error page pointing out you have some extra work to do and a link to the docs page for the extra info.
TODO
- Try to DRY up the code for these error pages
Screenshot
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration JavaScript Repository CLI Installation Language & Strings Front End Templates (site) |
I have tested this item
very cool!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21287.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21287.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21287.
Conflicts please
| Labels |
Added:
?
|
||
Rebased.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-30 05:39:31 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
?
|
||
Thanks
I have tested this item✅ successfully on 9e8aadb
Works as described
Just i can not do much of code review on this PR, as i do not have enough knowledge for this
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21287.