? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
28 Jul 2018

Pull Request for Issue # .

Summary of Changes

  • added missing dependency popper (although we don't really need it, it's already in the dist folder of BS4)
  • Removed a warning for not setting the source for the maps in postCss
  • Renamed argument --update to --copy-assets to better reflect the task
  • Updated some dev dependencies to eliminate critical warnings
  • updated the available arguments:
/**
 * Command line helper
 *
 * To get the complete functional media folder please run
 *
 * npm install
 *
 * For dedicated tasks, please run:
 * node build.js --installer      === will create the error page (for unsupported PHP version)
 * node build.js --copy-assets     === will clean the media/vendor folder and then will populate the folder from node_modules
 * node build.js --compile-js      === will transpile ES6 files and also uglify the ES6,ES5 files
 * node build.js --compile-ce      === will compile all the given CE or WC with their relative css files
 * node build.js --compile-css     === will compile all the scss defined files and also create a minified version of the css
 *
 */

Testing Instructions

All the npm related cli commands still execute the correct tasks

Expected result

Actual result

Documentation Changes Required

avatar dgrammatiko dgrammatiko - open - 28 Jul 2018
avatar dgrammatiko dgrammatiko - change - 28 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2018
Category JavaScript Repository
avatar dgrammatiko dgrammatiko - change - 28 Jul 2018
Labels Added: ?
6aeb34e 28 Jul 2018 avatar dgrammatiko fixes
avatar wilsonge wilsonge - change - 28 Jul 2018
Title
[4.0] Some fixes for the nom cli
[4.0] Some fixes for the npm cli
avatar wilsonge wilsonge - edited - 28 Jul 2018
avatar dgrammatiko dgrammatiko - change - 28 Jul 2018
The description was changed
avatar dgrammatiko dgrammatiko - edited - 28 Jul 2018
a2241ce 28 Jul 2018 avatar dgrammatiko more
avatar laoneo
laoneo - comment - 28 Jul 2018

Why is popper.js a dependency?

avatar dgrammatiko
dgrammatiko - comment - 28 Jul 2018

there is a warning that BS4 depends on popper.js and people feel uncofortable with warnings. But we definitely don't needed it

avatar rdeutz
rdeutz - comment - 28 Jul 2018

you need to change the package.json script calls

avatar dgrammatiko
dgrammatiko - comment - 28 Jul 2018

@rdeutz done

avatar rdeutz rdeutz - change - 29 Jul 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-07-29 12:20:43
Closed_By rdeutz
avatar rdeutz rdeutz - close - 29 Jul 2018
avatar rdeutz rdeutz - merge - 29 Jul 2018

Add a Comment

Login with GitHub to post a comment