[#21274] - Fixed users router
- Closed
- 12 May 2019
- Medium
- Build: staging
- # 21274
- Diff
- alexandraciobica:fix_users_router_3.x
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Failure JTracker/HumanTestResults Human Test Results: 0 Successful 2 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Added checks for the layout in the com_users router because at the moment the router returns the first menu item that has the view that we are searching for, not taking into consideration the layout.
Testing Instructions
- Create a menu item for "User profile", another one for "Edit user profile"
- From "User profile" click "Edit Profile" button, which is redirecting to the edit profile view, having the correct url. (The url was
/alias-of-menu-item/profile?layout=edit, now it is only/alias-of-menu-item) - From "edit user profile" click cancel button. Before these changes it redirected to the same page, now it goes to the "user profile" page.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
I have tested this item
Patch installed got at click "Edit Profile" button:
The requested URL /<br /><b>Notice</b>: Undefined index: layout in <b>/url-of-host/components/com_users/helpers/legacyrouter.php</b> on line <b>127</b><br />/index.php/en/user-profile was not found on this server.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21274.
I have tested this item
Before installing the patch,
at user profile url was:
index.php/user-profile/profile
we clicked edit profile, and on cancel we went back to
index.php/your-profile/profile
When I applied the test, I received the following warnings:
At http://localhost/demo_patches/index.php/edit-user-profile
Notice: Undefined index: layout in components/com_users/helpers/legacyrouter.php on line 131
At http://localhost/demo_patches/index.php/user-profile
Notice: Undefined index: layout in components/com_users/helpers/legacyrouter.php on line
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21274.
| Title |
|
||||||
@alexandraciobica whats the State of this Pull Request?
I suggest to close this PR due the lack of response by @alexandraciobica. In the meantime i add the label "needs new owner".
Closing. Can be reopened if judged necessary.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-12 07:03:31 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
Removed: J3 Issue |
||
I have tested this item🔴 unsuccessfully on 4d0e9f6
Patch installed got at click "Edit Profile" button:
The requested URL /<br /><b>Notice</b>: Undefined index: layout in <b>/url-of-host/components/com_users/helpers/legacyrouter.php</b> on line <b>127</b><br />/index.php/en/user-profile was not found on this server.At Menu User-Profile:
Notice: Undefined variable: profileEdit in/url-of-host/components/com_users/helpers/legacyrouter.php on line 222System information
CloudAccess.net
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21274.