? Pending

User tests: Successful: Unsuccessful:

avatar sabaturgay
sabaturgay
25 Jul 2018

Pull Request for Issue #20608 .

Summary of Changes

installed web installer and add function onInstallerAddInstallationTab to webinstaller.php

Testing Instructions

install => install from web plugin
Extensions => Plugins
Search Tools => installer
Disable other installer plugins
Return install extensions page

Expected result

Before fix: You should see error text
After fix: There should be no error text

avatar sabaturgay sabaturgay - open - 25 Jul 2018
avatar sabaturgay sabaturgay - change - 25 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2018
Category Front End Plugins JavaScript
avatar mbabker
mbabker - comment - 25 Jul 2018

Not quite sure what the intent here is, but the install from web plugin is not part of the core package for 3.x releases and AFAIK there are no plans to include it in one.

If you are looking to make changes to the plugin, https://github.com/joomla-extensions/install-from-web-client is the repo to do that in.

avatar sabaturgay
sabaturgay - comment - 25 Jul 2018

Hi, I dont want to insert web installer to joomla core. I just want to fix the issue and I cant explain that how we can fix the issue without installing web installer plugin.

avatar mbabker
mbabker - comment - 25 Jul 2018

Best advice I can give for that is to install the plugin locally, make your changes, then submit them as a pull request to the other repository I linked. It'll be much easier to review the changes because it'll only be a comparison of the actual changes, whereas here it's just adding a bunch of new files which makes it difficult to review.

avatar sabaturgay
sabaturgay - comment - 25 Jul 2018

Thank you for the advice. I will try it.

avatar roland-d
roland-d - comment - 25 Jul 2018
avatar roland-d roland-d - change - 25 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-25 13:10:06
Closed_By roland-d
Labels Added: ?
avatar roland-d roland-d - close - 25 Jul 2018

Add a Comment

Login with GitHub to post a comment