J4 Issue ?
avatar obsidev
obsidev
24 Jul 2018

Steps to reproduce the issue

Edit the Global configuration and provide an incorrect value for "session lifetime" : 19999
(it is possible to bypass the maximum value of the input field, which is 16383)

Expected result

The configuration is not saved and the user get a error message with the explanation of the issue.

Actual result

Configuration not saved but an exception is thrown "no database selected".

System information (as much as possible)

Joomla 4 Alpha 4

Additional comments

The "no database selected" is due to the call of $model->save while the validation returns a "false".
There is no "return;" after the $this->setRedirect
CF : https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_config/Controller/ApplicationController.php#L122

Even with the return, the error messages are not enqueued by the model and thus you don't get the validation error message.

avatar obsidev obsidev - open - 24 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 Jul 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Jul 2018
Category com_config
avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Jul 2018
Status New Confirmed
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Jul 2018

Issue confirmed.

avatar brianteeman brianteeman - change - 30 Jul 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 30 Jul 2018
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2018
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 3 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Aug 2018
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2018-08-03 10:56:46
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Aug 2018

closed as having Pull Request #21384

Add a Comment

Login with GitHub to post a comment