[#21244] - [4.0] Bootstrap 4 dropped btn-xs buttons.
- Closed
- 22 May 2019
- Medium
- Build: master
- # 21244
What needs to be fixed
CF : https://getbootstrap.com/docs/4.0/migration/#buttons
Dropped the .btn-xs class entirely as .btn-sm is proportionally much smaller than v3’s.
Why this should be fixed
The PR #15658 already migrated buttons from BS2 to BS4 ; but since then, there was some modifications in Bootstrap (it was an alpha).
How would you fix it
Looks like the btn-xs should be migrated into btn-sm
Side Effects expected
These btn-xs buttons are displayed as regular big buttons.
For example, there are the " grid.order " buttons.
| Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Status | New | ⇒ | Discussion |
The issue can also be seen in the backend, so in "atum" template.
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_buttons.scss
Nevertheless, I'm not sure that it would be the best to add CSS rules in template(s) for that since it is something which has been removed in BS4. It would mean that every templates would have to add these rules and couldn't use official BS4 just like that.
brianteeman
- | Labels |
Added:
J4 Issue
|
||
can I do it for atum template??
Sure, go for it.
@puneeth2001 is there a Pull Request coming?
| Status | Discussion | ⇒ | Information Required |
Not anytime soon, I am planning to work on it after a couple of days.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-04 07:00:53 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2019-04-04 07:00:53 | ⇒ | 2019-04-04 07:00:55 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/21244
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-04-04 07:00:55 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
| Status | New | ⇒ | Pending |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ |
Set to "open" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/21244
Per wilconge:
Remove the class usage
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21244.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-22 11:09:56 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_Date | 2019-05-22 11:09:56 | ⇒ | 2019-05-22 11:09:57 |
| Closed_By | joomla-cms-bot | ⇒ | Quy |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/21244
Please test PR #24979
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21244.
Already done for Casseopiea just FYI: https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/cassiopeia/scss/vendor/bootstrap/_buttons.scss#L3