Joomla! Issue Tracker | Joomla! CMS #21243 - [4.0] Namespace libraries/src

Fixed in Code Base
25 Jul 2018
Medium
Build: 4.0-dev
# 21243
Diff
brianteeman:namespace_library_src

Pending

Pending Hound Hound is busy reviewing changes... Details

User tests: Successful: Unsuccessful:

brianteeman
24 Jul 2018

Continuing the namespace work

NOTE there are a lot of files in this folder and its hard to separate into smaller pr so I have decided to do it in batches ie test and merge this one which is the main namespacing and then do subsequent pr once merged for the remaining namespaces

cca56db 24 Jul 2018

JFactory

c72390b 24 Jul 2018

JText

0a25507 24 Jul 2018

JHTML

8070b0d 24 Jul 2018

jaccessrules

4197e41 24 Jul 2018

JDatabasedriver

ac3febd 24 Jul 2018

JDatabaseQuery

85f6cdc 24 Jul 2018

Inputfilter outputfilter

747b89a 24 Jul 2018

jffile

brianteeman - open - 24 Jul 2018

brianteeman - change - 24 Jul 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 24 Jul 2018

Category

⇒

Libraries

267affb 24 Jul 2018

Use FQ class name

wilsonge - change - 24 Jul 2018

Labels

Added: ?

fd82a71 24 Jul 2018

Add input filter import

brianteeman - comment - 24 Jul 2018

(currently unable to connect to ci.joomla.org to see what the drone errors are)

rdeutz - comment - 24 Jul 2018

code style issues are the reason

brianteeman - comment - 24 Jul 2018

I will have to look at it another day as for some reason my internet connection will not route to ci.joomla.ory so that I can see the issues

rdeutz - comment - 24 Jul 2018

I can help :-)


FILE: ...thub.com/joomla/joomla-cms/libraries/src/Installer/InstallerAdapter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 125 | ERROR | Expected 2 spaces after the longest type
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ne/src/github.com/joomla/joomla-cms/libraries/src/Schema/ChangeItem.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 120 | ERROR | The variable names for parameters $db (1) and $file (2) do not
     |       | align
 137 | ERROR | The variable names for parameters $db (1) and $file (2) do not
     |       | align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...one/src/github.com/joomla/joomla-cms/libraries/src/Schema/ChangeSet.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
  66 | ERROR | The variable names for parameters $db (1) and $folder (2) do not
     |       | align
 143 | ERROR | The variable names for parameters $db (1) and $folder (2) do not
     |       | align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /drone/src/github.com/joomla/joomla-cms/libraries/src/UCM/UCMType.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 86 | ERROR | The variable names for parameters $alias (1) and $database (2) do
    |       | not align
 87 | ERROR | The variable names for parameters $database (2) and $application
    |       | (3) do not align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /drone/src/github.com/joomla/joomla-cms/libraries/src/Date/Date.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 429 | ERROR | The variable names for parameters $local (1) and $db (2) do not
     |       | align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: /drone/src/github.com/joomla/joomla-cms/libraries/src/Table/Table.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 140 | ERROR | The variable names for parameters $key (2) and $db (3) do not
     |       | align
 141 | ERROR | The variable names for parameters $db (3) and $dispatcher (4) do
     |       | not align
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

brianteeman - comment - 24 Jul 2018

It will still have to wait until tomorrow as I am out for the evening. Unless you want to do a pr to my branch:)

ec66e11 25 Jul 2018

fix drone

wilsonge - change - 25 Jul 2018

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2018-07-25 22:10:28
Closed_By		⇒	wilsonge

wilsonge - close - 25 Jul 2018

wilsonge - merge - 25 Jul 2018

wilsonge - comment - 25 Jul 2018

Thanks!

brianteeman - comment - 25 Jul 2018

Thanks. Now to re-review this folder for the less common stuff

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#21243] - [4.0] Namespace libraries/src

Add a Comment