Feeling Lucky
?
[#21233] - Fix error from PR #12543
- Closed
- 24 Jul 2018
- Medium
- Build: staging
- # 21233
- Diff
- Tchangue:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
The PR here #12543 generates an JS error, which is already in the system. This PR fix the error.
Testing Instructions
Apply the mentioned PR => JS error appears, apply patch => error disappear.
Expected result
No JS error
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration Templates (admin) |
infograf768
- comment
- 23 Jul 2018
One cannot add a PR to correct an error in a PR which is not merged yet.
In this case, it is better to correct the original PR or IF the original coder has disappeared, redo a full PR containing the whole code and all specific testing instructions, then add Bugsquad to close the original PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21233.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-24 08:18:28 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
|
||
@Tchangue
One cannot add a PR to correct an error in a PR which is not merged yet.
In this case, it is better to correct the original PR or IF the original coder has disappeared, redo a full PR containing the whole code and all specific testing instructions, then ask Bugsquad to close the original PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21233.