[#21180] - [3.x FIX] Getting the correct associations in sidebyside view for contact and newsfeeds
- Fixed in Code Base
- 24 Jul 2018
- Medium
- Build: staging
- # 21180
- Diff
- infograf768:3x-sidebyside
User tests: Successful: Unsuccessful:
Pull Request for Issue #21178
Summary of Changes
Changing #Jform_title to #Jform_name as these components are using name instead of title.
Thanks @SharkyKZ for the hint.
Steps to reproduce the issue
Create a multingual site. 2 languages are enough.
Create a contact in each language and associate them in their edit page.
Load Multilingual Associations component.
Select Contact as type and one fo the languages.
Click on the greyed icon in the Associations column.
This will load the side by side page.
Expected result
When using the Associations Tab for the reference and the target items, the field for the other language should display the name of the associated contact.
Actual result
It does not.
As you can see in the animated gif below, it does flash the name for a second at reload, then disapears as soon as the Target finishes loading.
After patch
Note
It will also work for newsfeeds.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations JavaScript |
Restarted drone...
I didn't get what to look for without PR. Reference and Target are loaded on Tab "Edit Contact", didn't see any Flash.
Can you please advice?
You have to display the Associations tab, not the Edit Contact
Combine these into one?
Combine these into one?
I don't think so. We have to differentiate them in the edit.php as well as in the sidebyside. js
Similar code to $this->referenceLanguage and $this->targetLanguage
If we wanted (but it adds a line), we would have
$this->title = AssociationsHelper::getTypeFieldName($extensionName, $typeName, 'title');
and then
$this->referenceTitle = $this->title;
and further
$this->targetTitle = $this->title;
$this->referenceLanguage and $this->targetLanguage refer to field values which can differ between reference/target. Meanwhile field names are always the same.
This can be simplified in the layout/js too by adding data attribute to the entire form, like data-associatedview
And without proposed change notice appears:
Notice: Undefined property: AssociationsViewAssociation::$targetTitle in /administrator/components/com_associations/views/association/tmpl/edit.php on line 59
@infograf768 no flashing: click on Tab "Associations" works as expected.
| Labels |
Added:
?
|
||
Notice: Undefined property: AssociationsViewAssociation::$targetTitle in /administrator/components/com_associations/views/association/tmpl/edit.php on line 59
I have corrected this as I did not test when there is NO association set. In that case indeed we have the Undefined property.
no flashing: click on Tab "Associations" works as expected.
When there are already associations, it does not as the wrong form is selected in sidebyside.js
Please re-read test instructions.
This can be simplified in the layout/js too by adding data attribute to the entire form, like data-associatedview
I will test this
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21180.
I get the following js error and the spinner did not end.
I have installed a new 3.8.10 with de & fr for all other i have followed the instructions.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21180.
@franz-wohlkoenig
Please test again. This time also look in the browser console. There should not be any more error message.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21180.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21180.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-24 00:15:12 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@infograf768 will test later on.