What happens if you replace both append()'s with appendChild()?

yes that fixes it

@C-Lodder @dgrammatiko can you do a pr to fix it

Sure, since we are here can I have an audit for the tabs component also from you, @brianteeman ?

you mean for a11y?
If so then I really would prefer it if you asked the a11y team

I have already the results of their audit I just wanted to see what you will come up also

I can tell you that it fails on a11y as there is no indicator that you are in a group of tabs or how many there are. It is keyboard accessible but not screenreader accessible

Here is an example of an accessible tab set
https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html

There may be other ways to achieve it. If you have nvda installed then you can easily compare this example with the joomla tab element

basically the screenreader should say something like
This is a group of 6 tabs, First tab - content
then
Second tab - images
etc

So instead of the <ul><li> we should have <button>, fairly easy change

weird - just restarted nvda and it announced the tabs correctly. Will have to look again and see what I did before that made it not work

ok found the problem, should be an easy fix that I will look at tonight
basically when you go to the second tab it announces
tab1title, tab2title tab 2 of 6

Not an easy fix at all. Spent some time with @fuzzbomb reviewing this verbosity last night. Not found a solution to it yet

@brianteeman let me know if you need some help here. I want to make another release of the custom elements before the next alpha release, so it would be great if we can tackle this issue as well

If you can fix the ie issue with appendchild I will keep looking into this verbosity issue

I'm gonna patch the append and some wrong id variable, later on and make another release

@brianteeman I confused what the actual issue is. The summary here says there's a rendering problem, but I don't think we talked about that at all.

I'm not convinced that the verbosity aspect amounts to a bug, we didn't get much time on it. Bear in mind that different screen readers have different philosophies about what to announce. It should be a separate issue, rather than conflate it with a rendering script error here.

@fuzzbomb ignore the rendering problem - thats something new and is apparently an IE 11 issue with tinymce that they are looking at it. The issue with the verbosity is the code in #21204

Would appreciate it if you were able to take a look at #21227 - dont worry if not. Or we can meetup sometime and look together

Closing this as ie11 is ok with the tabs now and the other issues can be addressed in their own issue