[#2116] - JImage: drop incorrect use of imagecopyresize
- Closed
- 8 Aug 2014
- Medium
- Build: master
- # 2116
- Diff
- piotr-cz:patch_JImage
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
There was a invisible bug in the resize method that showed up when I've implemented SCALE_FIT functionality - I didn't have time to update last commit like in the Framework, which is attached here. Below is explanation what it's all about.
The class didn't evaluate loaded image be transparent (see fix) and thus was always using imagecopyresampled function and everything seemed alright.
After the patch resource handle is evaluated to be transparent and imagecopyresized method produces visually poor results.
After little research I'm not sure, why it's even been used; I hope the author @rvsjoen can say something about it.
It seems that imagecopyresized is quite faster, but still would be used for wrong reasons.
Other frameworks:
-
Lavarell Resizer bundle uses just
imagecopyresampled - Symfony too
- Kohana as well
Resources:
- TuxRadar: Scaling and rotating
- StackOverflow: php imagecopyresized vs imagecopyresampled
- php.blogle.info: Performance comparison
- random search result showing difference in quality
Updated to current staging branch.
This PR is outdated and to the wrong branch. Please do a new PR with against "staging" with the specific improvement. Thank you!
Closed as per the comment on the tracker
Rebased again on staging branch.
To test, see first commit before rebase craziness started.
Superseded by #4234
Issue tracker item: 3221